diff options
author | Yoshiya Hinosawa <stibium121@gmail.com> | 2024-10-16 20:58:44 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-10-16 20:58:44 +0900 |
commit | d59599fc187c559ee231882773e1c5a2b932fc3d (patch) | |
tree | 3719d26bee7ce395afd28e4ab631dc5e63021327 /ext/node/polyfills/internal/dns/utils.ts | |
parent | ea9c3ffaa240fc968832871000832eda1b92934a (diff) |
fix(ext/node): fix dns.lookup result ordering (#26264)
partially unblocks #25470
This PR aligns the resolution of `localhost` hostname to Node.js
behavior.
In Node.js `dns.lookup("localhost", (_, addr) => console.log(addr))`
prints ipv6 address `::1`, but it prints ipv4 address `127.0.0.1` in
Deno. That difference causes some errors in the work of enabling
`createConnection` option in `http.request` (#25470). This PR fixes the
issue by aligning `dns.lookup` behavior to Node.js.
This PR also changes the following behaviors (resolving TODOs):
- `http.createServer` now listens on ipv6 address `[::]` by default on
linux/mac
- `net.createServer` now listens on ipv6 address `[::]` by default on
linux/mac
These changes are also alignments to Node.js behaviors.
Diffstat (limited to 'ext/node/polyfills/internal/dns/utils.ts')
-rw-r--r-- | ext/node/polyfills/internal/dns/utils.ts | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/ext/node/polyfills/internal/dns/utils.ts b/ext/node/polyfills/internal/dns/utils.ts index 226fce93d..1e0c3d9ed 100644 --- a/ext/node/polyfills/internal/dns/utils.ts +++ b/ext/node/polyfills/internal/dns/utils.ts @@ -416,20 +416,10 @@ export function emitInvalidHostnameWarning(hostname: string) { ); } -let dnsOrder = getOptionValue("--dns-result-order") || "ipv4first"; +let dnsOrder = getOptionValue("--dns-result-order") || "verbatim"; export function getDefaultVerbatim() { - switch (dnsOrder) { - case "verbatim": { - return true; - } - case "ipv4first": { - return false; - } - default: { - return false; - } - } + return dnsOrder !== "ipv4first"; } /** |