diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-03-04 22:31:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-05 02:31:38 +0000 |
commit | b40086fd7da3729d1d59b312c89ee57747fc66a9 (patch) | |
tree | 991583010635feab13fae77e7c8a35fef0a09095 /ext/node/polyfills/internal/console | |
parent | 01028fcdf4f379a7285cc15079306e3ac31edcc1 (diff) |
refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
Diffstat (limited to 'ext/node/polyfills/internal/console')
-rw-r--r-- | ext/node/polyfills/internal/console/constructor.mjs | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/ext/node/polyfills/internal/console/constructor.mjs b/ext/node/polyfills/internal/console/constructor.mjs index 362c97f68..8c9a6d390 100644 --- a/ext/node/polyfills/internal/console/constructor.mjs +++ b/ext/node/polyfills/internal/console/constructor.mjs @@ -8,12 +8,12 @@ import { ERR_INCOMPATIBLE_OPTION_PAIR, ERR_INVALID_ARG_VALUE, isStackOverflowError, -} from "internal:deno_node/polyfills/internal/errors.ts"; +} from "internal:deno_node/internal/errors.ts"; import { validateArray, validateInteger, validateObject, -} from "internal:deno_node/polyfills/internal/validators.mjs"; +} from "internal:deno_node/internal/validators.mjs"; const previewEntries = (iter, isKeyValue) => { if (isKeyValue) { const arr = [...iter]; @@ -25,24 +25,24 @@ const previewEntries = (iter, isKeyValue) => { return [...iter]; } }; -import { Buffer } from "internal:deno_node/polyfills/buffer.ts"; +import { Buffer } from "internal:deno_node/buffer.ts"; const { isBuffer } = Buffer; -import { formatWithOptions, inspect } from "internal:deno_node/polyfills/internal/util/inspect.mjs"; +import { formatWithOptions, inspect } from "internal:deno_node/internal/util/inspect.mjs"; import { isMap, isMapIterator, isSet, isSetIterator, isTypedArray, -} from "internal:deno_node/polyfills/internal/util/types.ts"; +} from "internal:deno_node/internal/util/types.ts"; import { CHAR_LOWERCASE_B as kTraceBegin, CHAR_LOWERCASE_E as kTraceEnd, CHAR_LOWERCASE_N as kTraceInstant, CHAR_UPPERCASE_C as kTraceCount, -} from "internal:deno_node/polyfills/internal/constants.ts"; -import { clearScreenDown, cursorTo } from "internal:deno_node/polyfills/internal/readline/callbacks.mjs"; -import cliTable from "internal:deno_node/polyfills/internal/cli_table.ts"; +} from "internal:deno_node/internal/constants.ts"; +import { clearScreenDown, cursorTo } from "internal:deno_node/internal/readline/callbacks.mjs"; +import cliTable from "internal:deno_node/internal/cli_table.ts"; const kCounts = Symbol("counts"); const kTraceConsoleCategory = "node,node.console"; |