diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-03-04 22:31:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-05 02:31:38 +0000 |
commit | b40086fd7da3729d1d59b312c89ee57747fc66a9 (patch) | |
tree | 991583010635feab13fae77e7c8a35fef0a09095 /ext/node/polyfills/child_process.ts | |
parent | 01028fcdf4f379a7285cc15079306e3ac31edcc1 (diff) |
refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.
Example:
```
include_js_files! {
dir "js",
"hello.js",
}
```
The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.
The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".
Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
Diffstat (limited to 'ext/node/polyfills/child_process.ts')
-rw-r--r-- | ext/node/polyfills/child_process.ts | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/ext/node/polyfills/child_process.ts b/ext/node/polyfills/child_process.ts index cc0e17ffb..fdcf32bca 100644 --- a/ext/node/polyfills/child_process.ts +++ b/ext/node/polyfills/child_process.ts @@ -2,7 +2,7 @@ // This module implements 'child_process' module of Node.JS API. // ref: https://nodejs.org/api/child_process.html -import { core } from "internal:deno_node/polyfills/_core.ts"; +import { core } from "internal:deno_node/_core.ts"; import { ChildProcess, ChildProcessOptions, @@ -12,13 +12,13 @@ import { type SpawnSyncOptions, type SpawnSyncResult, stdioStringToArray, -} from "internal:deno_node/polyfills/internal/child_process.ts"; +} from "internal:deno_node/internal/child_process.ts"; import { validateAbortSignal, validateFunction, validateObject, validateString, -} from "internal:deno_node/polyfills/internal/validators.mjs"; +} from "internal:deno_node/internal/validators.mjs"; import { ERR_CHILD_PROCESS_IPC_REQUIRED, ERR_CHILD_PROCESS_STDIO_MAXBUFFER, @@ -26,7 +26,7 @@ import { ERR_INVALID_ARG_VALUE, ERR_OUT_OF_RANGE, genericNodeError, -} from "internal:deno_node/polyfills/internal/errors.ts"; +} from "internal:deno_node/internal/errors.ts"; import { ArrayIsArray, ArrayPrototypeJoin, @@ -34,18 +34,15 @@ import { ArrayPrototypeSlice, ObjectAssign, StringPrototypeSlice, -} from "internal:deno_node/polyfills/internal/primordials.mjs"; -import { - getSystemErrorName, - promisify, -} from "internal:deno_node/polyfills/util.ts"; -import { createDeferredPromise } from "internal:deno_node/polyfills/internal/util.mjs"; -import process from "internal:deno_node/polyfills/process.ts"; -import { Buffer } from "internal:deno_node/polyfills/buffer.ts"; +} from "internal:deno_node/internal/primordials.mjs"; +import { getSystemErrorName, promisify } from "internal:deno_node/util.ts"; +import { createDeferredPromise } from "internal:deno_node/internal/util.mjs"; +import process from "internal:deno_node/process.ts"; +import { Buffer } from "internal:deno_node/buffer.ts"; import { convertToValidSignal, kEmptyObject, -} from "internal:deno_node/polyfills/internal/util.mjs"; +} from "internal:deno_node/internal/util.mjs"; const MAX_BUFFER = 1024 * 1024; |