summaryrefslogtreecommitdiff
path: root/ext/node/polyfills/_stream.mjs
diff options
context:
space:
mode:
authorYoshiya Hinosawa <stibium121@gmail.com>2024-04-08 12:47:34 +0900
committerGitHub <noreply@github.com>2024-04-08 12:47:34 +0900
commit2670c1d580320ed01d3a7add27bc5db2a23ac80b (patch)
tree0bad7c76feaaa06c88cc42cafb8d7689a8e0f199 /ext/node/polyfills/_stream.mjs
parent49f6e2e79e66fe2c456e8745e86cfd148a748c9d (diff)
fix(ext/node): out-of-order writes of fs.createWriteStream (#23244)
This PR follows this fix (https://github.com/nodejs/node/pull/52005) in Node.js. Stream's construct callback happens one tick earlier by this change, and it prevents the reordering of the first few chunks in `node:stream.Writable` closes #20284
Diffstat (limited to 'ext/node/polyfills/_stream.mjs')
-rw-r--r--ext/node/polyfills/_stream.mjs5
1 files changed, 1 insertions, 4 deletions
diff --git a/ext/node/polyfills/_stream.mjs b/ext/node/polyfills/_stream.mjs
index 6b772ac04..591f8bb51 100644
--- a/ext/node/polyfills/_stream.mjs
+++ b/ext/node/polyfills/_stream.mjs
@@ -1665,7 +1665,7 @@ var require_destroy = __commonJS({
} else if (err) {
errorOrDestroy(stream, err, true);
} else {
- process.nextTick(emitConstructNT, stream);
+ stream.emit(kConstruct);
}
}
try {
@@ -1676,9 +1676,6 @@ var require_destroy = __commonJS({
nextTick(onConstruct, err);
}
}
- function emitConstructNT(stream) {
- stream.emit(kConstruct);
- }
function isRequest(stream) {
return stream && stream.setHeader && typeof stream.abort === "function";
}