summaryrefslogtreecommitdiff
path: root/ext/node/ops/http2.rs
diff options
context:
space:
mode:
authorSatya Rohith <me@satyarohith.com>2024-06-10 20:00:56 +0530
committerGitHub <noreply@github.com>2024-06-10 16:30:56 +0200
commit4fd3d5a86e45c4dcbaaa277cfb7f1087ddebfa48 (patch)
tree1540c8e62d50f61a83647831f9beea2837a0299f /ext/node/ops/http2.rs
parent3be0a1e8b44782b2d3c3970e0e6fa7fb11be8131 (diff)
fix(ext/node): send data frame with end_stream flag on _final call (#24147)
Diffstat (limited to 'ext/node/ops/http2.rs')
-rw-r--r--ext/node/ops/http2.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/node/ops/http2.rs b/ext/node/ops/http2.rs
index e206db61b..abf7eae5d 100644
--- a/ext/node/ops/http2.rs
+++ b/ext/node/ops/http2.rs
@@ -344,6 +344,7 @@ pub async fn op_http2_client_send_data(
state: Rc<RefCell<OpState>>,
#[smi] stream_rid: ResourceId,
#[buffer] data: JsBuffer,
+ end_of_stream: bool,
) -> Result<(), AnyError> {
let resource = state
.borrow()
@@ -351,8 +352,7 @@ pub async fn op_http2_client_send_data(
.get::<Http2ClientStream>(stream_rid)?;
let mut stream = RcRef::map(&resource, |r| &r.stream).borrow_mut().await;
- // TODO(bartlomieju): handle end of stream
- stream.send_data(data.to_vec().into(), false)?;
+ stream.send_data(data.to_vec().into(), end_of_stream)?;
Ok(())
}