diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-01-05 18:28:33 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-05 18:28:33 +0530 |
| commit | df062d2c788fd76546d59c67452d8d0fe569c533 (patch) | |
| tree | b82a837378469c3eb1456aeea40354601b040793 /ext/node/lib.rs | |
| parent | bac51f66aa89dd9b79a3c4e844423c3a3399ea13 (diff) | |
fix(ext/node): add fs.cp, fs.cpSync, promises.cp (#21745)
Fixes https://github.com/denoland/deno/issues/20803
Fixes https://github.com/denoland/deno/issues/21723
Performance: copying a 48GiB rust `target` folder (recursive)
| Platform | `deno` | `node v21.5` | Improvement |
| -------- | ------- | ------- | ------- |
| macOS (APFS) | 3.1secs | 127.99 secs | **42x** |
| Windows | 18.3secs | 67.2secs | **3.8x** |
Copying files with varying sizes:
Diffstat (limited to 'ext/node/lib.rs')
| -rw-r--r-- | ext/node/lib.rs | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/ext/node/lib.rs b/ext/node/lib.rs index 2aac49754..de56285fd 100644 --- a/ext/node/lib.rs +++ b/ext/node/lib.rs @@ -63,6 +63,11 @@ pub trait NodePermissions { api_name: Option<&str>, ) -> Result<(), AnyError>; fn check_sys(&self, kind: &str, api_name: &str) -> Result<(), AnyError>; + fn check_write_with_api_name( + &self, + path: &Path, + api_name: Option<&str>, + ) -> Result<(), AnyError>; } pub(crate) struct AllowAllNodePermissions; @@ -82,6 +87,13 @@ impl NodePermissions for AllowAllNodePermissions { ) -> Result<(), AnyError> { Ok(()) } + fn check_write_with_api_name( + &self, + _path: &Path, + _api_name: Option<&str>, + ) -> Result<(), AnyError> { + Ok(()) + } fn check_sys(&self, _kind: &str, _api_name: &str) -> Result<(), AnyError> { Ok(()) } @@ -238,6 +250,8 @@ deno_core::extension!(deno_node, ops::crypto::x509::op_node_x509_get_serial_number, ops::crypto::x509::op_node_x509_key_usage, ops::fs::op_node_fs_exists_sync<P>, + ops::fs::op_node_cp_sync<P>, + ops::fs::op_node_cp<P>, ops::winerror::op_node_sys_to_uv_error, ops::v8::op_v8_cached_data_version_tag, ops::v8::op_v8_get_heap_statistics, @@ -329,6 +343,7 @@ deno_core::extension!(deno_node, "_fs/_fs_common.ts", "_fs/_fs_constants.ts", "_fs/_fs_copy.ts", + "_fs/_fs_cp.js", "_fs/_fs_dir.ts", "_fs/_fs_dirent.ts", "_fs/_fs_exists.ts", |