diff options
| author | Nayeem Rahman <nayeemrmn99@gmail.com> | 2023-08-06 00:47:15 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-06 01:47:15 +0200 |
| commit | c1c8eb3d558bedf6588179ae93737bd6afe5a368 (patch) | |
| tree | e6ba4d8aa59a8b73e224fd218cf6e102a81974d9 /ext/node/lib.rs | |
| parent | b96f28306490a56aac91b8ef06b35ebdc7f41b63 (diff) | |
build: allow disabling snapshots for dev (#20048)
Closes #19399 (running without snapshots at all was suggested as an
alternative solution).
Adds a `__runtime_js_sources` pseudo-private feature to load extension
JS sources at runtime for faster development, instead of building and
loading snapshots or embedding sources in the binary. Will only work in
a development environment obviously.
Try running `cargo test --features __runtime_js_sources
integration::node_unit_tests::os_test`. Then break some behaviour in
`ext/node/polyfills/os.ts` e.g. make `function cpus() {}` return an
empty array, and run it again. Fix and then run again. No more build
time in between.
Diffstat (limited to 'ext/node/lib.rs')
| -rw-r--r-- | ext/node/lib.rs | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/ext/node/lib.rs b/ext/node/lib.rs index 40330dc5b..e2643a84f 100644 --- a/ext/node/lib.rs +++ b/ext/node/lib.rs @@ -132,12 +132,7 @@ pub static NODE_ENV_VAR_ALLOWLIST: Lazy<HashSet<String>> = Lazy::new(|| { #[op] fn op_node_build_os() -> String { - std::env::var("TARGET") - .unwrap() - .split('-') - .nth(2) - .unwrap() - .to_string() + env!("TARGET").split('-').nth(2).unwrap().to_string() } #[op(fast)] |