diff options
| author | Matt Mastracci <matthew@mastracci.com> | 2023-03-17 16:15:27 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-17 22:15:27 +0000 |
| commit | 3487fde236d0852a8b0672c293fa41a741f471e8 (patch) | |
| tree | af466368147a08b787080446319a3a46a60ee37d /ext/node/lib.rs | |
| parent | e55b448730160a6e4df9815a268d4049ac89deab (diff) | |
perf(core) Reduce copying and cloning in extension initialization (#18252)
Follow-up to #18210:
* we are passing the generated `cfg` object into the state function
rather than passing individual config fields
* reduce cloning dramatically by making the state_fn `FnOnce`
* `take` for `ExtensionBuilder` to avoid more unnecessary copies
* renamed `config` to `options`
Diffstat (limited to 'ext/node/lib.rs')
| -rw-r--r-- | ext/node/lib.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ext/node/lib.rs b/ext/node/lib.rs index 06138cf4c..23a003bc8 100644 --- a/ext/node/lib.rs +++ b/ext/node/lib.rs @@ -370,11 +370,11 @@ deno_core::extension!(deno_node_loading, ops::op_require_break_on_next_statement, ], esm = ["01_node.js", "02_require.js", "module_es_shim.js"], - config = { + options = { maybe_npm_resolver: Option<Rc<dyn RequireNpmResolver>>, }, - state = |state, maybe_npm_resolver| { - if let Some(npm_resolver) = maybe_npm_resolver.clone() { + state = |state, options| { + if let Some(npm_resolver) = options.maybe_npm_resolver { state.put(npm_resolver); } }, |