diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2024-06-19 15:09:17 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-19 16:09:17 +0200 |
commit | b94707af7df757db13f24b7b70dbd7956d1e1e1c (patch) | |
tree | 5e2ce944f66f4fda8b0982b68e7e422c2960753a /ext/net | |
parent | f4eead61ebd0af203784134c0a8b6339874531b5 (diff) |
Revert "chore: upgrade to reqwest 0.12.4 and rustls 0.22 (#24056)" (#24262)
This reverts commit fb31eaa9ca59f6daaee0210d5cd206185c7041b9.
Reverting because users reported spurious errors when downloading
dependencies - https://github.com/denoland/deno/issues/24260.
Closes https://github.com/denoland/deno/issues/24260
Diffstat (limited to 'ext/net')
-rw-r--r-- | ext/net/ops_tls.rs | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/ext/net/ops_tls.rs b/ext/net/ops_tls.rs index ccea8eb75..c52985908 100644 --- a/ext/net/ops_tls.rs +++ b/ext/net/ops_tls.rs @@ -31,11 +31,11 @@ use deno_tls::create_client_config; use deno_tls::load_certs; use deno_tls::load_private_keys; use deno_tls::new_resolver; -use deno_tls::rustls::pki_types::ServerName; +use deno_tls::rustls::Certificate; use deno_tls::rustls::ClientConnection; +use deno_tls::rustls::PrivateKey; use deno_tls::rustls::ServerConfig; -use deno_tls::webpki::types::CertificateDer; -use deno_tls::webpki::types::PrivateKeyDer; +use deno_tls::rustls::ServerName; use deno_tls::ServerConfigProvider; use deno_tls::SocketUse; use deno_tls::TlsKey; @@ -48,6 +48,7 @@ use serde::Deserialize; use std::borrow::Cow; use std::cell::RefCell; use std::convert::From; +use std::convert::TryFrom; use std::fs::File; use std::io::BufReader; use std::io::ErrorKind; @@ -303,14 +304,14 @@ where { let rid = args.rid; let hostname = match &*args.hostname { - "" => "localhost".to_string(), - n => n.to_string(), + "" => "localhost", + n => n, }; { let mut s = state.borrow_mut(); let permissions = s.borrow_mut::<NP>(); - permissions.check_net(&(&hostname, Some(0)), "Deno.startTls()")?; + permissions.check_net(&(hostname, Some(0)), "Deno.startTls()")?; } let ca_certs = args @@ -319,8 +320,8 @@ where .map(|s| s.into_bytes()) .collect::<Vec<_>>(); - let hostname_dns = ServerName::try_from(hostname.to_string()) - .map_err(|_| invalid_hostname(&hostname))?; + let hostname_dns = + ServerName::try_from(hostname).map_err(|_| invalid_hostname(hostname))?; let unsafely_ignore_certificate_errors = state .borrow() @@ -421,9 +422,9 @@ where .borrow::<DefaultTlsOptions>() .root_cert_store()?; let hostname_dns = if let Some(server_name) = args.server_name { - ServerName::try_from(server_name) + ServerName::try_from(server_name.as_str()) } else { - ServerName::try_from(addr.hostname.clone()) + ServerName::try_from(&*addr.hostname) } .map_err(|_| invalid_hostname(&addr.hostname))?; let connect_addr = resolve_addr(&addr.hostname, addr.port) @@ -465,9 +466,7 @@ where Ok((rid, IpAddr::from(local_addr), IpAddr::from(remote_addr))) } -fn load_certs_from_file( - path: &str, -) -> Result<Vec<CertificateDer<'static>>, AnyError> { +fn load_certs_from_file(path: &str) -> Result<Vec<Certificate>, AnyError> { let cert_file = File::open(path)?; let reader = &mut BufReader::new(cert_file); load_certs(reader) @@ -475,7 +474,7 @@ fn load_certs_from_file( fn load_private_keys_from_file( path: &str, -) -> Result<Vec<PrivateKeyDer<'static>>, AnyError> { +) -> Result<Vec<PrivateKey>, AnyError> { let key_bytes = std::fs::read(path)?; load_private_keys(&key_bytes) } @@ -524,6 +523,7 @@ where TlsKeys::Null => Err(anyhow!("Deno.listenTls requires a key")), TlsKeys::Static(TlsKey(cert, key)) => { let mut tls_config = ServerConfig::builder() + .with_safe_defaults() .with_no_client_auth() .with_single_cert(cert, key) .map_err(|e| anyhow!(e))?; |