refactor: Use ES modules for internal runtime code (#17648)

This PR refactors all internal js files (except core) to be written as
ES modules.
`__bootstrap`has been mostly replaced with static imports in form in
`internal:[path to file from repo root]`.
To specify if files are ESM, an `esm` method has been added to
`Extension`, similar to the `js` method.
A new ModuleLoader called `InternalModuleLoader` has been added to
enable the loading of internal specifiers, which is used in all
situations except when a snapshot is only loaded, and not a new one is
created from it.

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

1 files changed, 353 insertions, 355 deletions

diff --git a/ext/net/01_net.js b/ext/net/01_net.js
index a6043786f..46561cae5 100644
--- a/ext/net/01_net.js
+++ b/ext/net/01_net.js
@@ -1,423 +1,421 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
-"use strict";
-
-((window) => {
-  const core = window.Deno.core;
-  const { BadResourcePrototype, InterruptedPrototype, ops } = core;
-  const {
-    readableStreamForRidUnrefable,
-    readableStreamForRidUnrefableRef,
-    readableStreamForRidUnrefableUnref,
-    writableStreamForRid,
-  } = window.__bootstrap.streams;
-  const {
-    Error,
-    ObjectPrototypeIsPrototypeOf,
-    PromiseResolve,
-    SymbolAsyncIterator,
-    SymbolFor,
-    TypedArrayPrototypeSubarray,
-    TypeError,
-    Uint8Array,
-  } = window.__bootstrap.primordials;
-
-  const promiseIdSymbol = SymbolFor("Deno.core.internalPromiseId");
-
-  async function write(rid, data) {
-    return await core.write(rid, data);
-  }
-
-  function shutdown(rid) {
-    return core.shutdown(rid);
-  }
-
-  function resolveDns(query, recordType, options) {
-    return core.opAsync("op_dns_resolve", { query, recordType, options });
-  }
-
-  class Conn {
-    #rid = 0;
-    #remoteAddr = null;
-    #localAddr = null;
-    #unref = false;
-    #pendingReadPromiseIds = [];
-
-    #readable;
-    #writable;
-
-    constructor(rid, remoteAddr, localAddr) {
-      this.#rid = rid;
-      this.#remoteAddr = remoteAddr;
-      this.#localAddr = localAddr;
-    }
 
-    get rid() {
-      return this.#rid;
-    }
+const core = globalThis.Deno.core;
+const { BadResourcePrototype, InterruptedPrototype, ops } = core;
+import {
+  readableStreamForRidUnrefable,
+  readableStreamForRidUnrefableRef,
+  readableStreamForRidUnrefableUnref,
+  writableStreamForRid,
+} from "internal:ext/web/06_streams.js";
+const primordials = globalThis.__bootstrap.primordials;
+const {
+  Error,
+  ObjectPrototypeIsPrototypeOf,
+  PromiseResolve,
+  SymbolAsyncIterator,
+  SymbolFor,
+  TypedArrayPrototypeSubarray,
+  TypeError,
+  Uint8Array,
+} = primordials;
+
+const promiseIdSymbol = SymbolFor("Deno.core.internalPromiseId");
+
+async function write(rid, data) {
+  return await core.write(rid, data);
+}
+
+function shutdown(rid) {
+  return core.shutdown(rid);
+}
+
+function resolveDns(query, recordType, options) {
+  return core.opAsync("op_dns_resolve", { query, recordType, options });
+}
+
+class Conn {
+  #rid = 0;
+  #remoteAddr = null;
+  #localAddr = null;
+  #unref = false;
+  #pendingReadPromiseIds = [];
+
+  #readable;
+  #writable;
+
+  constructor(rid, remoteAddr, localAddr) {
+    this.#rid = rid;
+    this.#remoteAddr = remoteAddr;
+    this.#localAddr = localAddr;
+  }
 
-    get remoteAddr() {
-      return this.#remoteAddr;
-    }
+  get rid() {
+    return this.#rid;
+  }
 
-    get localAddr() {
-      return this.#localAddr;
-    }
+  get remoteAddr() {
+    return this.#remoteAddr;
+  }
 
-    write(p) {
-      return write(this.rid, p);
-    }
+  get localAddr() {
+    return this.#localAddr;
+  }
 
-    async read(buffer) {
-      if (buffer.length === 0) {
-        return 0;
-      }
-      const promise = core.read(this.rid, buffer);
-      const promiseId = promise[promiseIdSymbol];
-      if (this.#unref) core.unrefOp(promiseId);
-      this.#pendingReadPromiseIds.push(promiseId);
-      let nread;
-      try {
-        nread = await promise;
-      } catch (e) {
-        throw e;
-      } finally {
-        this.#pendingReadPromiseIds = this.#pendingReadPromiseIds.filter((id) =>
-          id !== promiseId
-        );
-      }
-      return nread === 0 ? null : nread;
-    }
+  write(p) {
+    return write(this.rid, p);
+  }
 
-    close() {
-      core.close(this.rid);
-    }
+  async read(buffer) {
+    if (buffer.length === 0) {
+      return 0;
+    }
+    const promise = core.read(this.rid, buffer);
+    const promiseId = promise[promiseIdSymbol];
+    if (this.#unref) core.unrefOp(promiseId);
+    this.#pendingReadPromiseIds.push(promiseId);
+    let nread;
+    try {
+      nread = await promise;
+    } catch (e) {
+      throw e;
+    } finally {
+      this.#pendingReadPromiseIds = this.#pendingReadPromiseIds.filter((id) =>
+        id !== promiseId
+      );
+    }
+    return nread === 0 ? null : nread;
+  }
 
-    closeWrite() {
-      return shutdown(this.rid);
-    }
+  close() {
+    core.close(this.rid);
+  }
 
-    get readable() {
-      if (this.#readable === undefined) {
-        this.#readable = readableStreamForRidUnrefable(this.rid);
-        if (this.#unref) {
-          readableStreamForRidUnrefableUnref(this.#readable);
-        }
-      }
-      return this.#readable;
-    }
+  closeWrite() {
+    return shutdown(this.rid);
+  }
 
-    get writable() {
-      if (this.#writable === undefined) {
-        this.#writable = writableStreamForRid(this.rid);
+  get readable() {
+    if (this.#readable === undefined) {
+      this.#readable = readableStreamForRidUnrefable(this.rid);
+      if (this.#unref) {
+        readableStreamForRidUnrefableUnref(this.#readable);
       }
-      return this.#writable;
     }
+    return this.#readable;
+  }
 
-    ref() {
-      this.#unref = false;
-      if (this.#readable) {
-        readableStreamForRidUnrefableRef(this.#readable);
-      }
-      this.#pendingReadPromiseIds.forEach((id) => core.refOp(id));
+  get writable() {
+    if (this.#writable === undefined) {
+      this.#writable = writableStreamForRid(this.rid);
     }
+    return this.#writable;
+  }
 
-    unref() {
-      this.#unref = true;
-      if (this.#readable) {
-        readableStreamForRidUnrefableUnref(this.#readable);
-      }
-      this.#pendingReadPromiseIds.forEach((id) => core.unrefOp(id));
+  ref() {
+    this.#unref = false;
+    if (this.#readable) {
+      readableStreamForRidUnrefableRef(this.#readable);
     }
+    this.#pendingReadPromiseIds.forEach((id) => core.refOp(id));
   }
 
-  class TcpConn extends Conn {
-    setNoDelay(noDelay = true) {
-      return ops.op_set_nodelay(this.rid, noDelay);
+  unref() {
+    this.#unref = true;
+    if (this.#readable) {
+      readableStreamForRidUnrefableUnref(this.#readable);
     }
+    this.#pendingReadPromiseIds.forEach((id) => core.unrefOp(id));
+  }
+}
 
-    setKeepAlive(keepAlive = true) {
-      return ops.op_set_keepalive(this.rid, keepAlive);
-    }
+class TcpConn extends Conn {
+  setNoDelay(noDelay = true) {
+    return ops.op_set_nodelay(this.rid, noDelay);
   }
 
-  class UnixConn extends Conn {}
+  setKeepAlive(keepAlive = true) {
+    return ops.op_set_keepalive(this.rid, keepAlive);
+  }
+}
 
-  class Listener {
-    #rid = 0;
-    #addr = null;
-    #unref = false;
-    #promiseId = null;
+class UnixConn extends Conn {}
 
-    constructor(rid, addr) {
-      this.#rid = rid;
-      this.#addr = addr;
-    }
+class Listener {
+  #rid = 0;
+  #addr = null;
+  #unref = false;
+  #promiseId = null;
 
-    get rid() {
-      return this.#rid;
-    }
+  constructor(rid, addr) {
+    this.#rid = rid;
+    this.#addr = addr;
+  }
 
-    get addr() {
-      return this.#addr;
-    }
+  get rid() {
+    return this.#rid;
+  }
 
-    async accept() {
-      let promise;
-      switch (this.addr.transport) {
-        case "tcp":
-          promise = core.opAsync("op_net_accept_tcp", this.rid);
-          break;
-        case "unix":
-          promise = core.opAsync("op_net_accept_unix", this.rid);
-          break;
-        default:
-          throw new Error(`Unsupported transport: ${this.addr.transport}`);
-      }
-      this.#promiseId = promise[promiseIdSymbol];
-      if (this.#unref) core.unrefOp(this.#promiseId);
-      const { 0: rid, 1: localAddr, 2: remoteAddr } = await promise;
-      this.#promiseId = null;
-      if (this.addr.transport == "tcp") {
-        localAddr.transport = "tcp";
-        remoteAddr.transport = "tcp";
-        return new TcpConn(rid, remoteAddr, localAddr);
-      } else if (this.addr.transport == "unix") {
-        return new UnixConn(
-          rid,
-          { transport: "unix", path: remoteAddr },
-          { transport: "unix", path: localAddr },
-        );
-      } else {
-        throw new Error("unreachable");
-      }
+  get addr() {
+    return this.#addr;
+  }
+
+  async accept() {
+    let promise;
+    switch (this.addr.transport) {
+      case "tcp":
+        promise = core.opAsync("op_net_accept_tcp", this.rid);
+        break;
+      case "unix":
+        promise = core.opAsync("op_net_accept_unix", this.rid);
+        break;
+      default:
+        throw new Error(`Unsupported transport: ${this.addr.transport}`);
+    }
+    this.#promiseId = promise[promiseIdSymbol];
+    if (this.#unref) core.unrefOp(this.#promiseId);
+    const { 0: rid, 1: localAddr, 2: remoteAddr } = await promise;
+    this.#promiseId = null;
+    if (this.addr.transport == "tcp") {
+      localAddr.transport = "tcp";
+      remoteAddr.transport = "tcp";
+      return new TcpConn(rid, remoteAddr, localAddr);
+    } else if (this.addr.transport == "unix") {
+      return new UnixConn(
+        rid,
+        { transport: "unix", path: remoteAddr },
+        { transport: "unix", path: localAddr },
+      );
+    } else {
+      throw new Error("unreachable");
     }
+  }
 
-    async next() {
-      let conn;
-      try {
-        conn = await this.accept();
-      } catch (error) {
-        if (
-          ObjectPrototypeIsPrototypeOf(BadResourcePrototype, error) ||
-          ObjectPrototypeIsPrototypeOf(InterruptedPrototype, error)
-        ) {
-          return { value: undefined, done: true };
-        }
-        throw error;
+  async next() {
+    let conn;
+    try {
+      conn = await this.accept();
+    } catch (error) {
+      if (
+        ObjectPrototypeIsPrototypeOf(BadResourcePrototype, error) ||
+        ObjectPrototypeIsPrototypeOf(InterruptedPrototype, error)
+      ) {
+        return { value: undefined, done: true };
       }
-      return { value: conn, done: false };
+      throw error;
     }
+    return { value: conn, done: false };
+  }
 
-    return(value) {
-      this.close();
-      return PromiseResolve({ value, done: true });
-    }
+  return(value) {
+    this.close();
+    return PromiseResolve({ value, done: true });
+  }
 
-    close() {
-      core.close(this.rid);
-    }
+  close() {
+    core.close(this.rid);
+  }
 
-    [SymbolAsyncIterator]() {
-      return this;
-    }
+  [SymbolAsyncIterator]() {
+    return this;
+  }
 
-    ref() {
-      this.#unref = false;
-      if (typeof this.#promiseId === "number") {
-        core.refOp(this.#promiseId);
-      }
+  ref() {
+    this.#unref = false;
+    if (typeof this.#promiseId === "number") {
+      core.refOp(this.#promiseId);
     }
+  }
 
-    unref() {
-      this.#unref = true;
-      if (typeof this.#promiseId === "number") {
-        core.unrefOp(this.#promiseId);
-      }
+  unref() {
+    this.#unref = true;
+    if (typeof this.#promiseId === "number") {
+      core.unrefOp(this.#promiseId);
     }
   }
+}
 
-  class Datagram {
-    #rid = 0;
-    #addr = null;
+class Datagram {
+  #rid = 0;
+  #addr = null;
 
-    constructor(rid, addr, bufSize = 1024) {
-      this.#rid = rid;
-      this.#addr = addr;
-      this.bufSize = bufSize;
-    }
-
-    get rid() {
-      return this.#rid;
-    }
+  constructor(rid, addr, bufSize = 1024) {
+    this.#rid = rid;
+    this.#addr = addr;
+    this.bufSize = bufSize;
+  }
 
-    get addr() {
-      return this.#addr;
-    }
+  get rid() {
+    return this.#rid;
+  }
 
-    async receive(p) {
-      const buf = p || new Uint8Array(this.bufSize);
-      let nread;
-      let remoteAddr;
-      switch (this.addr.transport) {
-        case "udp": {
-          ({ 0: nread, 1: remoteAddr } = await core.opAsync(
-            "op_net_recv_udp",
-            this.rid,
-            buf,
-          ));
-          remoteAddr.transport = "udp";
-          break;
-        }
-        case "unixpacket": {
-          let path;
-          ({ 0: nread, 1: path } = await core.opAsync(
-            "op_net_recv_unixpacket",
-            this.rid,
-            buf,
-          ));
-          remoteAddr = { transport: "unixpacket", path };
-          break;
-        }
-        default:
-          throw new Error(`Unsupported transport: ${this.addr.transport}`);
-      }
-      const sub = TypedArrayPrototypeSubarray(buf, 0, nread);
-      return [sub, remoteAddr];
-    }
+  get addr() {
+    return this.#addr;
+  }
 
-    async send(p, opts) {
-      switch (this.addr.transport) {
-        case "udp":
-          return await core.opAsync(
-            "op_net_send_udp",
-            this.rid,
-            { hostname: opts.hostname ?? "127.0.0.1", port: opts.port },
-            p,
-          );
-        case "unixpacket":
-          return await core.opAsync(
-            "op_net_send_unixpacket",
-            this.rid,
-            opts.path,
-            p,
-          );
-        default:
-          throw new Error(`Unsupported transport: ${this.addr.transport}`);
+  async receive(p) {
+    const buf = p || new Uint8Array(this.bufSize);
+    let nread;
+    let remoteAddr;
+    switch (this.addr.transport) {
+      case "udp": {
+        ({ 0: nread, 1: remoteAddr } = await core.opAsync(
+          "op_net_recv_udp",
+          this.rid,
+          buf,
+        ));
+        remoteAddr.transport = "udp";
+        break;
       }
-    }
-
-    close() {
-      core.close(this.rid);
-    }
-
-    async *[SymbolAsyncIterator]() {
-      while (true) {
-        try {
-          yield await this.receive();
-        } catch (err) {
-          if (
-            ObjectPrototypeIsPrototypeOf(BadResourcePrototype, err) ||
-            ObjectPrototypeIsPrototypeOf(InterruptedPrototype, err)
-          ) {
-            break;
-          }
-          throw err;
-        }
+      case "unixpacket": {
+        let path;
+        ({ 0: nread, 1: path } = await core.opAsync(
+          "op_net_recv_unixpacket",
+          this.rid,
+          buf,
+        ));
+        remoteAddr = { transport: "unixpacket", path };
+        break;
       }
+      default:
+        throw new Error(`Unsupported transport: ${this.addr.transport}`);
     }
+    const sub = TypedArrayPrototypeSubarray(buf, 0, nread);
+    return [sub, remoteAddr];
   }
 
-  function listen(args) {
-    switch (args.transport ?? "tcp") {
-      case "tcp": {
-        const { 0: rid, 1: addr } = ops.op_net_listen_tcp({
-          hostname: args.hostname ?? "0.0.0.0",
-          port: args.port,
-        }, args.reusePort);
-        addr.transport = "tcp";
-        return new Listener(rid, addr);
-      }
-      case "unix": {
-        const { 0: rid, 1: path } = ops.op_net_listen_unix(args.path);
-        const addr = {
-          transport: "unix",
-          path,
-        };
-        return new Listener(rid, addr);
-      }
+  async send(p, opts) {
+    switch (this.addr.transport) {
+      case "udp":
+        return await core.opAsync(
+          "op_net_send_udp",
+          this.rid,
+          { hostname: opts.hostname ?? "127.0.0.1", port: opts.port },
+          p,
+        );
+      case "unixpacket":
+        return await core.opAsync(
+          "op_net_send_unixpacket",
+          this.rid,
+          opts.path,
+          p,
+        );
       default:
-        throw new TypeError(`Unsupported transport: '${transport}'`);
+        throw new Error(`Unsupported transport: ${this.addr.transport}`);
     }
   }
 
-  function createListenDatagram(udpOpFn, unixOpFn) {
-    return function listenDatagram(args) {
-      switch (args.transport) {
-        case "udp": {
-          const { 0: rid, 1: addr } = udpOpFn(
-            {
-              hostname: args.hostname ?? "127.0.0.1",
-              port: args.port,
-            },
-            args.reuseAddress ?? false,
-          );
-          addr.transport = "udp";
-          return new Datagram(rid, addr);
-        }
-        case "unixpacket": {
-          const { 0: rid, 1: path } = unixOpFn(args.path);
-          const addr = {
-            transport: "unixpacket",
-            path,
-          };
-          return new Datagram(rid, addr);
+  close() {
+    core.close(this.rid);
+  }
+
+  async *[SymbolAsyncIterator]() {
+    while (true) {
+      try {
+        yield await this.receive();
+      } catch (err) {
+        if (
+          ObjectPrototypeIsPrototypeOf(BadResourcePrototype, err) ||
+          ObjectPrototypeIsPrototypeOf(InterruptedPrototype, err)
+        ) {
+          break;
         }
-        default:
-          throw new TypeError(`Unsupported transport: '${transport}'`);
+        throw err;
       }
-    };
+    }
+  }
+}
+
+function listen(args) {
+  switch (args.transport ?? "tcp") {
+    case "tcp": {
+      const { 0: rid, 1: addr } = ops.op_net_listen_tcp({
+        hostname: args.hostname ?? "0.0.0.0",
+        port: args.port,
+      }, args.reusePort);
+      addr.transport = "tcp";
+      return new Listener(rid, addr);
+    }
+    case "unix": {
+      const { 0: rid, 1: path } = ops.op_net_listen_unix(args.path);
+      const addr = {
+        transport: "unix",
+        path,
+      };
+      return new Listener(rid, addr);
+    }
+    default:
+      throw new TypeError(`Unsupported transport: '${transport}'`);
   }
+}
 
-  async function connect(args) {
-    switch (args.transport ?? "tcp") {
-      case "tcp": {
-        const { 0: rid, 1: localAddr, 2: remoteAddr } = await core.opAsync(
-          "op_net_connect_tcp",
+function createListenDatagram(udpOpFn, unixOpFn) {
+  return function listenDatagram(args) {
+    switch (args.transport) {
+      case "udp": {
+        const { 0: rid, 1: addr } = udpOpFn(
           {
             hostname: args.hostname ?? "127.0.0.1",
             port: args.port,
           },
+          args.reuseAddress ?? false,
         );
-        localAddr.transport = "tcp";
-        remoteAddr.transport = "tcp";
-        return new TcpConn(rid, remoteAddr, localAddr);
+        addr.transport = "udp";
+        return new Datagram(rid, addr);
       }
-      case "unix": {
-        const { 0: rid, 1: localAddr, 2: remoteAddr } = await core.opAsync(
-          "op_net_connect_unix",
-          args.path,
-        );
-        return new UnixConn(
-          rid,
-          { transport: "unix", path: remoteAddr },
-          { transport: "unix", path: localAddr },
-        );
+      case "unixpacket": {
+        const { 0: rid, 1: path } = unixOpFn(args.path);
+        const addr = {
+          transport: "unixpacket",
+          path,
+        };
+        return new Datagram(rid, addr);
       }
       default:
         throw new TypeError(`Unsupported transport: '${transport}'`);
     }
-  }
-
-  window.__bootstrap.net = {
-    connect,
-    Conn,
-    TcpConn,
-    UnixConn,
-    listen,
-    createListenDatagram,
-    Listener,
-    shutdown,
-    Datagram,
-    resolveDns,
   };
-})(this);
+}
+
+async function connect(args) {
+  switch (args.transport ?? "tcp") {
+    case "tcp": {
+      const { 0: rid, 1: localAddr, 2: remoteAddr } = await core.opAsync(
+        "op_net_connect_tcp",
+        {
+          hostname: args.hostname ?? "127.0.0.1",
+          port: args.port,
+        },
+      );
+      localAddr.transport = "tcp";
+      remoteAddr.transport = "tcp";
+      return new TcpConn(rid, remoteAddr, localAddr);
+    }
+    case "unix": {
+      const { 0: rid, 1: localAddr, 2: remoteAddr } = await core.opAsync(
+        "op_net_connect_unix",
+        args.path,
+      );
+      return new UnixConn(
+        rid,
+        { transport: "unix", path: remoteAddr },
+        { transport: "unix", path: localAddr },
+      );
+    }
+    default:
+      throw new TypeError(`Unsupported transport: '${transport}'`);
+  }
+}
+
+export {
+  Conn,
+  connect,
+  createListenDatagram,
+  Datagram,
+  listen,
+  Listener,
+  resolveDns,
+  shutdown,
+  TcpConn,
+  UnixConn,
+};