refactor: make 'rid' properties non-enumerable (#22137)

Now these props will not show up when inspecting objects in console.

1 files changed, 17 insertions, 8 deletions

diff --git a/ext/net/01_net.js b/ext/net/01_net.js
index 8dbf32625..9b13fcf26 100644
--- a/ext/net/01_net.js
+++ b/ext/net/01_net.js
@@ -34,6 +34,7 @@ const {
   Error,
   Number,
   ObjectPrototypeIsPrototypeOf,
+  ObjectDefineProperty,
   PromiseResolve,
   SafeSet,
   SetPrototypeAdd,
@@ -91,7 +92,6 @@ async function resolveDns(query, recordType, options) {
 }
 
 class Conn {
-  [internalRidSymbol] = 0;
   #rid = 0;
   #remoteAddr = null;
   #localAddr = null;
@@ -102,7 +102,10 @@ class Conn {
   #writable;
 
   constructor(rid, remoteAddr, localAddr) {
-    this[internalRidSymbol] = rid;
+    ObjectDefineProperty(this, internalRidSymbol, {
+      enumerable: false,
+      value: rid,
+    });
     this.#rid = rid;
     this.#remoteAddr = remoteAddr;
     this.#localAddr = localAddr;
@@ -201,12 +204,14 @@ class Conn {
 }
 
 class TcpConn extends Conn {
-  [internalRidSymbol] = 0;
   #rid = 0;
 
   constructor(rid, remoteAddr, localAddr) {
     super(rid, remoteAddr, localAddr);
-    this[internalRidSymbol] = rid;
+    ObjectDefineProperty(this, internalRidSymbol, {
+      enumerable: false,
+      value: rid,
+    });
     this.#rid = rid;
   }
 
@@ -229,12 +234,14 @@ class TcpConn extends Conn {
 }
 
 class UnixConn extends Conn {
-  [internalRidSymbol] = 0;
   #rid = 0;
 
   constructor(rid, remoteAddr, localAddr) {
     super(rid, remoteAddr, localAddr);
-    this[internalRidSymbol] = rid;
+    ObjectDefineProperty(this, internalRidSymbol, {
+      enumerable: false,
+      value: rid,
+    });
     this.#rid = rid;
   }
 
@@ -249,14 +256,16 @@ class UnixConn extends Conn {
 }
 
 class Listener {
-  [internalRidSymbol] = 0;
   #rid = 0;
   #addr = null;
   #unref = false;
   #promise = null;
 
   constructor(rid, addr) {
-    this[internalRidSymbol] = rid;
+    ObjectDefineProperty(this, internalRidSymbol, {
+      enumerable: false,
+      value: rid,
+    });
     this.#rid = rid;
     this.#addr = addr;
   }