diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-05-08 22:45:06 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-08 22:45:06 -0400 |
| commit | 47f7bed677a6b72e873712de8f3988ea891710e4 (patch) | |
| tree | 096549459b479cf1383e65c87b77e9f9482df258 /ext/io | |
| parent | e6dc4dfbff25e77d2127591802229b4a74037d24 (diff) | |
chore: enable clippy::print_stdout and clippy::print_stderr (#23732)
1. Generally we should prefer to use the `log` crate.
2. I very often accidentally commit `eprintln`s.
When we should use `println` or `eprintln`, it's not too bad to be a bit
more verbose and ignore the lint rule.
Diffstat (limited to 'ext/io')
| -rw-r--r-- | ext/io/Cargo.toml | 1 | ||||
| -rw-r--r-- | ext/io/winpipe.rs | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/ext/io/Cargo.toml b/ext/io/Cargo.toml index 17a967834..70b5c63f8 100644 --- a/ext/io/Cargo.toml +++ b/ext/io/Cargo.toml @@ -18,6 +18,7 @@ async-trait.workspace = true deno_core.workspace = true filetime.workspace = true fs3.workspace = true +log.workspace = true once_cell.workspace = true tokio.workspace = true diff --git a/ext/io/winpipe.rs b/ext/io/winpipe.rs index f66dec6b6..01d018008 100644 --- a/ext/io/winpipe.rs +++ b/ext/io/winpipe.rs @@ -74,7 +74,7 @@ fn create_named_pipe_inner() -> io::Result<(RawHandle, RawHandle)> { // This should not happen, so we would like to get some better diagnostics here. // SAFETY: Printing last error for diagnostics unsafe { - eprintln!( + log::error!( "*** Unexpected server pipe failure '{pipe_name:?}': {:x}", GetLastError() ); @@ -99,7 +99,7 @@ fn create_named_pipe_inner() -> io::Result<(RawHandle, RawHandle)> { // SAFETY: Getting last error for diagnostics let error = unsafe { GetLastError() }; // This should not happen, so we would like to get some better diagnostics here. - eprintln!( + log::error!( "*** Unexpected client pipe failure '{pipe_name:?}': {:x}", error ); |