summaryrefslogtreecommitdiff
path: root/ext/http/lib.rs
diff options
context:
space:
mode:
authorMatt Mastracci <matthew@mastracci.com>2023-09-11 18:06:38 -0600
committerGitHub <noreply@github.com>2023-09-12 00:06:38 +0000
commit950e0e9cd65bd634d59fe60d5a0cb8651958c7fb (patch)
tree400dd0eaacf7ce1018a07e2e232e6d62f54112ad /ext/http/lib.rs
parentbfd230fd78ef7867eec75e6b21715f51e72e7a23 (diff)
fix(ext/http): create a graceful shutdown API (#20387)
This PR implements a graceful shutdown API for Deno.serve, allowing all current connections to drain from the server before shutting down, while preventing new connections from being started or new transactions on existing connections from being created. We split the cancellation handle into two parts: a listener handle, and a connection handle. A graceful shutdown cancels the listener only, while allowing the connections to drain. The connection handle aborts all futures. If the listener handle is cancelled, we put the connections into graceful shutdown mode, which disables keep-alive on http/1.1 and uses http/2 mechanisms for http/2 connections. In addition, we now guarantee that all connections are complete or cancelled, and all resources are cleaned up when the server `finished` promise resolves -- we use a Rust-side server refcount for this. Performance impact: does not appear to affect basic serving performance by more than 1% (~126k -> ~125k) --------- Co-authored-by: Bartek IwaƄczuk <biwanczuk@gmail.com>
Diffstat (limited to 'ext/http/lib.rs')
-rw-r--r--ext/http/lib.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/ext/http/lib.rs b/ext/http/lib.rs
index 93ea0895e..719dcd6de 100644
--- a/ext/http/lib.rs
+++ b/ext/http/lib.rs
@@ -126,6 +126,8 @@ deno_core::extension!(
http_next::op_can_write_vectored,
http_next::op_http_try_wait,
http_next::op_http_wait,
+ http_next::op_http_close,
+ http_next::op_http_cancel,
],
esm = ["00_serve.js", "01_http.js"],
);