summaryrefslogtreecommitdiff
path: root/ext/http/01_http.js
diff options
context:
space:
mode:
authorLeo K <crowlkats@toaxl.com>2021-10-26 23:06:44 +0200
committerGitHub <noreply@github.com>2021-10-26 23:06:44 +0200
commit6268703487da02d66552d1e1a42858aa273def90 (patch)
tree04bb51cfb65d733132ceb6b435dbec77fd544a1d /ext/http/01_http.js
parent9161e74a7dc8e0ff2c49bb9ca53895a6d49b5838 (diff)
fix(ext/http): allow multiple values in upgrade header for websocket (#12551)
Co-authored-by: Aaron O'Mullan <aaron.omullan@gmail.com>
Diffstat (limited to 'ext/http/01_http.js')
-rw-r--r--ext/http/01_http.js11
1 files changed, 8 insertions, 3 deletions
diff --git a/ext/http/01_http.js b/ext/http/01_http.js
index 9ce6997c6..9f05809f5 100644
--- a/ext/http/01_http.js
+++ b/ext/http/01_http.js
@@ -349,9 +349,14 @@
function upgradeWebSocket(request, options = {}) {
const upgrade = request.headers.get("upgrade");
- if (!upgrade || StringPrototypeToLowerCase(upgrade) !== "websocket") {
+ const upgradeHasWebSocketOption = upgrade !== null &&
+ ArrayPrototypeSome(
+ StringPrototypeSplit(upgrade, /\s*,\s*/),
+ (option) => StringPrototypeToLowerCase(option) === "websocket",
+ );
+ if (!upgradeHasWebSocketOption) {
throw new TypeError(
- "Invalid Header: 'upgrade' header must be 'websocket'",
+ "Invalid Header: 'upgrade' header must contain 'websocket'",
);
}
@@ -363,7 +368,7 @@
);
if (!connectionHasUpgradeOption) {
throw new TypeError(
- "Invalid Header: 'connection' header must be 'Upgrade'",
+ "Invalid Header: 'connection' header must contain 'Upgrade'",
);
}