diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-03-09 10:56:19 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-09 14:56:19 +0000 |
commit | 8f207c0f3f3a43d77e0c88cfdc840b4b742b9708 (patch) | |
tree | a8699bca5ffffff03a9d72f1bed9208a349338ba /ext/fs | |
parent | 99da8a69e7260b72e55d7214ec96f6ac5e759f35 (diff) |
refactor: Split extension registration for runtime and snapshotting (#18095)
This commit splits "<ext_name>::init" functions into "init_ops" and
"init_ops_and_esm". That way we don't have to construct list of
ESM sources on each startup if we're running with a snapshot.
In a follow up commit "deno_core" will be changed to not have a split
between "extensions" and "extensions_with_js" - it will be embedders'
responsibility to pass appropriately configured extensions.
Prerequisite for https://github.com/denoland/deno/pull/18080
Diffstat (limited to 'ext/fs')
-rw-r--r-- | ext/fs/lib.rs | 24 |
1 files changed, 22 insertions, 2 deletions
diff --git a/ext/fs/lib.rs b/ext/fs/lib.rs index 4b177a2bf..31782d38d 100644 --- a/ext/fs/lib.rs +++ b/ext/fs/lib.rs @@ -9,6 +9,7 @@ use deno_core::op; use deno_core::CancelFuture; use deno_core::CancelHandle; use deno_core::Extension; +use deno_core::ExtensionBuilder; use deno_core::OpState; use deno_core::ResourceId; use deno_core::ZeroCopyBuf; @@ -117,9 +118,15 @@ use deno_core::error::generic_error; #[cfg(not(unix))] use deno_core::error::not_supported; -pub fn init<P: FsPermissions + 'static>(unstable: bool) -> Extension { +fn ext() -> ExtensionBuilder { Extension::builder("deno_fs") - .esm(include_js_files!("30_fs.js",)) +} + +fn ops<P: FsPermissions + 'static>( + ext: &mut ExtensionBuilder, + unstable: bool, +) -> &mut ExtensionBuilder { + ext .state(move |state| { state.put(UnstableChecker { unstable }); }) @@ -184,6 +191,19 @@ pub fn init<P: FsPermissions + 'static>(unstable: bool) -> Extension { op_readfile_async::decl::<P>(), op_readfile_text_async::decl::<P>(), ]) +} + +pub fn init_ops_and_esm<P: FsPermissions + 'static>( + unstable: bool, +) -> Extension { + ops::<P>(&mut ext(), unstable) + .esm(include_js_files!("30_fs.js",)) + .build() +} + +pub fn init_ops<P: FsPermissions + 'static>(unstable: bool) -> Extension { + ops::<P>(&mut ext(), unstable) + .esm(include_js_files!("30_fs.js",)) .build() } |