diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-07-17 05:35:51 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-17 18:05:51 +0530 |
| commit | 078def0ff8501bb07f3f286515acd8c6a2181037 (patch) | |
| tree | 6811ec33761ede11e5213393e7ea3732fd54f292 /ext/fs/interface.rs | |
| parent | 568dd132fb0a47f9afb11bffec341c7481dda75c (diff) | |
perf(ext/node): optimize fs.exists[Sync] (#24613)
Use `access` on *nix and `GetFileAttributesW` on Windows.
[Benchmark](https://paste.divy.work/p/-gq8Ark.js):
```
$ deno run -A bench.mjs # main (568dd)
existsSync: 8980.636629ms
$ target/release/deno run -A bench.mjs # this PR
existsSync: 6448.7604519999995ms
$ bun bench.mjs
existsSync: 6562.88671ms
$ node bench.mjs
existsSync: 7740.064653ms
```
Ref https://github.com/denoland/deno/pull/24434#discussion_r1679777912
Diffstat (limited to 'ext/fs/interface.rs')
| -rw-r--r-- | ext/fs/interface.rs | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ext/fs/interface.rs b/ext/fs/interface.rs index 2fdfa2186..09e16aff1 100644 --- a/ext/fs/interface.rs +++ b/ext/fs/interface.rs @@ -315,6 +315,9 @@ pub trait FileSystem: std::fmt::Debug + MaybeSend + MaybeSync { fn exists_sync(&self, path: &Path) -> bool { self.stat_sync(path).is_ok() } + async fn exists_async(&self, path: PathBuf) -> FsResult<bool> { + Ok(self.stat_async(path).await.is_ok()) + } fn read_text_file_lossy_sync( &self, |