diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-05-08 22:45:06 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-08 22:45:06 -0400 |
| commit | 47f7bed677a6b72e873712de8f3988ea891710e4 (patch) | |
| tree | 096549459b479cf1383e65c87b77e9f9482df258 /ext/ffi | |
| parent | e6dc4dfbff25e77d2127591802229b4a74037d24 (diff) | |
chore: enable clippy::print_stdout and clippy::print_stderr (#23732)
1. Generally we should prefer to use the `log` crate.
2. I very often accidentally commit `eprintln`s.
When we should use `println` or `eprintln`, it's not too bad to be a bit
more verbose and ignore the lint rule.
Diffstat (limited to 'ext/ffi')
| -rw-r--r-- | ext/ffi/Cargo.toml | 1 | ||||
| -rw-r--r-- | ext/ffi/callback.rs | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/ext/ffi/Cargo.toml b/ext/ffi/Cargo.toml index 9e6ade702..8af1b2016 100644 --- a/ext/ffi/Cargo.toml +++ b/ext/ffi/Cargo.toml @@ -19,6 +19,7 @@ dlopen2.workspace = true dynasmrt = "1.2.3" libffi = "=3.2.0" libffi-sys = "=2.3.0" +log.workspace = true serde.workspace = true serde-value = "0.7" serde_json = "1.0" diff --git a/ext/ffi/callback.rs b/ext/ffi/callback.rs index eeea49c23..55f38c602 100644 --- a/ext/ffi/callback.rs +++ b/ext/ffi/callback.rs @@ -176,7 +176,7 @@ unsafe extern "C" fn deno_ffi_callback( let tc_scope = &mut TryCatch::new(scope); args.run(tc_scope); if tc_scope.exception().is_some() { - eprintln!("Illegal unhandled exception in nonblocking callback."); + log::error!("Illegal unhandled exception in nonblocking callback."); } }); } |