diff options
author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-03-12 10:42:26 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-03-12 10:42:26 -0700 |
commit | de28e6fc09f30c05a38c257137ee8d15150cc1a6 (patch) | |
tree | 037be759d6d754a5d88146bfe07c8b7033882bda /ext/fetch | |
parent | 4a88695563ced73e18a97be06f9f0864be683eff (diff) |
refactor: add `deno_permissions` crate (#22236)
Issue https://github.com/denoland/deno/issues/22222

This PR moves `runtime/permissions` code to a upstream crate called
`deno_permissions`. The `deno_permissions::PermissionsContainer` is put
into the OpState and can be used instead of the current trait-based
permissions system.
For this PR, I've migrated `deno_fetch` to the new crate but kept the
rest of the trait-based system as a wrapper of `deno_permissions` crate.
Doing the migration all at once is error prone and hard to review.
Comparing incremental compile times for `ext/fetch` on Mac M1:
| profile | `cargo build --bin deno` | `cargo plonk build --bin deno` |
| --------- | ------------- | ------------------- |
| `debug` | 20 s | 0.8s |
| `release` | 4 mins 12 s | 1.4s |
Diffstat (limited to 'ext/fetch')
-rw-r--r-- | ext/fetch/lib.rs | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/ext/fetch/lib.rs b/ext/fetch/lib.rs index 02ce34810..aeac33973 100644 --- a/ext/fetch/lib.rs +++ b/ext/fetch/lib.rs @@ -168,15 +168,6 @@ impl FetchHandler for DefaultFileFetchHandler { } } -pub trait FetchPermissions { - fn check_net_url( - &mut self, - _url: &Url, - api_name: &str, - ) -> Result<(), AnyError>; - fn check_read(&mut self, _p: &Path, api_name: &str) -> Result<(), AnyError>; -} - pub fn get_declaration() -> PathBuf { PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("lib.deno_fetch.d.ts") } @@ -268,6 +259,15 @@ impl Drop for ResourceToBodyAdapter { } } +pub trait FetchPermissions { + fn check_net_url( + &mut self, + _url: &Url, + api_name: &str, + ) -> Result<(), AnyError>; + fn check_read(&mut self, _p: &Path, api_name: &str) -> Result<(), AnyError>; +} + #[op2] #[serde] #[allow(clippy::too_many_arguments)] |