summaryrefslogtreecommitdiff
path: root/ext/fetch/26_fetch.js
diff options
context:
space:
mode:
authorAndreu Botella <abb@randomunok.com>2021-10-10 07:03:23 -0700
committerGitHub <noreply@github.com>2021-10-10 16:03:23 +0200
commit5edd2771619ddc3cd2f6c76cc93ee64277aa17c2 (patch)
tree88307d65fc81388579328dfb7d3da782ffa3f5a9 /ext/fetch/26_fetch.js
parent6ac0337165d5e341eee9bff9ff0065894289df69 (diff)
feat: Show the URL of streaming WASM modules in stack traces (#12268)
WebAssembly modules compiled through `WebAssembly.compile()` and similar non-streaming APIs don't have a URL associated to them, because they have been compiled from a buffer source. In stack traces, V8 will use a URL such as `wasm://wasm/d1c677ea`, with a hash of the module. However, wasm modules compiled through streaming APIs, like `WebAssembly.compileStreaming()`, do have a known URL, which can be obtained from the `Response` object passed into the streaming APIs. And as per the developer-facing display conventions in the WebAssembly Web API spec, this URL should be used in stack traces. This change implements that.
Diffstat (limited to 'ext/fetch/26_fetch.js')
-rw-r--r--ext/fetch/26_fetch.js3
1 files changed, 3 insertions, 0 deletions
diff --git a/ext/fetch/26_fetch.js b/ext/fetch/26_fetch.js
index f74726242..fcfa75318 100644
--- a/ext/fetch/26_fetch.js
+++ b/ext/fetch/26_fetch.js
@@ -526,6 +526,9 @@
throw new TypeError(`HTTP status code ${res.status}`);
}
+ // Pass the resolved URL to v8.
+ core.opSync("op_wasm_streaming_set_url", rid, res.url);
+
// 2.6.
// Rather than consuming the body as an ArrayBuffer, this passes each
// chunk to the feed as soon as it's available.