summaryrefslogtreecommitdiff
path: root/ext/fetch/23_request.js
diff options
context:
space:
mode:
authorMatt Mastracci <matthew@mastracci.com>2024-04-25 14:52:24 -0400
committerGitHub <noreply@github.com>2024-04-25 14:52:24 -0400
commit084eafe50883bc69ae2700023f6c74db03185ba4 (patch)
tree35eea8b51c2eebc0525f79296035456a969a7890 /ext/fetch/23_request.js
parentbc4aa5f901d7bb9d83a18c14ab54ffafe014ccf9 (diff)
perf(ext/http): recover memory for serve and optimize AbortController (#23559)
Max rps without a signal is unchanged, however we can drastically reduce memory usage by not creating the signal until needed, and we can optimize the rps in the case where the signal is created. With a quick memory benchmark, it looks like this helps pretty drastically with # of GCs when benchmarking w/wrk: - 1.42.4: 1763 - canary: 1093 - this patch: 874 This branch: ``` Running 10s test @ http://localhost:8080/ 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 87.33us 439.95us 20.68ms 99.67% Req/Sec 66.70k 6.39k 74.11k 83.66% 1340255 requests in 10.10s, 191.73MB read Requests/sec: 132696.90 Transfer/sec: 18.98MB cpu: Apple M2 Pro runtime: deno 1.43.0 (aarch64-apple-darwin) file:///Users/matt/Documents/scripts/bench_request.js benchmark time (avg) iter/s (min … max) p75 p99 p995 ----------------------------------------------------------------------------------------------- ----------------------------- newRequest 986.5 ns/iter 1,013,682.6 (878.2 ns … 1.18 µs) 1.01 µs 1.18 µs 1.18 µs newAbortController 18 ns/iter 55,541,104.1 (15.6 ns … 42.62 ns) 17.71 ns 25.05 ns 26.27 ns newAbortControllerSignal 18.66 ns/iter 53,578,966.7 (16.49 ns … 32.16 ns) 18.71 ns 25.67 ns 26.39 ns newAbortControllerSignalOnAbort 106.49 ns/iter 9,390,164.9 (97.87 ns … 120.61 ns) 108.6 ns 114.24 ns 115.89 ns newAbortControllerSignalAddEventListener 86.92 ns/iter 11,504,880.2 (81.88 ns … 103.15 ns) 90 ns 98.28 ns 99.55 ns newAbortControllerSignalOnAbortNoListener 3.01 µs/iter 331,964.4 (2.97 µs … 3.1 µs) 3.06 µs 3.1 µs 3.1 µs newAbortControllerSignalOnAbortAbort 3.26 µs/iter 306,662.6 (3.22 µs … 3.36 µs) 3.27 µs 3.36 µs 3.36 µs ``` Latest canary: ``` Running 10s test @ http://localhost:8080/ 2 threads and 10 connections Thread Stats Avg Stdev Max +/- Stdev Latency 72.86us 71.23us 4.47ms 99.05% Req/Sec 64.66k 5.54k 72.48k 82.18% 1299015 requests in 10.10s, 185.83MB read Requests/sec: 128616.02 Transfer/sec: 18.40MB cpu: Apple M2 Pro runtime: deno 1.43.0+bc4aa5f (aarch64-apple-darwin) file:///Users/matt/Documents/scripts/bench_request.js benchmark time (avg) iter/s (min … max) p75 p99 p995 ----------------------------------------------------------------------------------------------- ----------------------------- newRequest 1.25 µs/iter 800,005.2 (1.01 µs … 4.18 µs) 1.16 µs 4.18 µs 4.18 µs newAbortController 18.56 ns/iter 53,868,204.3 (16.04 ns … 38.73 ns) 18.38 ns 26.1 ns 26.63 ns newAbortControllerSignal 18.72 ns/iter 53,430,746.1 (16.13 ns … 36.71 ns) 18.71 ns 26.19 ns 26.98 ns newAbortControllerSignalOnAbort 193.91 ns/iter 5,156,992.4 (184.25 ns … 211.41 ns) 194.96 ns 207.87 ns 209.4 ns newAbortControllerSignalAddEventListener 171.45 ns/iter 5,832,569.2 (153 ns … 182.03 ns) 176.17 ns 180.75 ns 181.05 ns newAbortControllerSignalOnAbortNoListener 3.07 µs/iter 326,263.3 (2.98 µs … 3.17 µs) 3.08 µs 3.17 µs 3.17 µs newAbortControllerSignalOnAbortAbort 3.32 µs/iter 301,344.6 (3.29 µs … 3.4 µs) 3.33 µs 3.4 µs 3.4 µs ```
Diffstat (limited to 'ext/fetch/23_request.js')
-rw-r--r--ext/fetch/23_request.js65
1 files changed, 45 insertions, 20 deletions
diff --git a/ext/fetch/23_request.js b/ext/fetch/23_request.js
index 61c3b3f5d..70e00a874 100644
--- a/ext/fetch/23_request.js
+++ b/ext/fetch/23_request.js
@@ -14,6 +14,7 @@ const {
ArrayPrototypeMap,
ArrayPrototypeSlice,
ArrayPrototypeSplice,
+ ObjectFreeze,
ObjectKeys,
ObjectPrototypeIsPrototypeOf,
RegExpPrototypeExec,
@@ -24,7 +25,6 @@ const {
} = primordials;
import * as webidl from "ext:deno_webidl/00_webidl.js";
-import { assert } from "ext:deno_web/00_infra.js";
import { createFilteredInspectProxy } from "ext:deno_console/01_console.js";
import {
byteUpperCase,
@@ -43,8 +43,12 @@ import {
headersFromHeaderList,
} from "ext:deno_fetch/20_headers.js";
import { HttpClientPrototype } from "ext:deno_fetch/22_http_client.js";
-import * as abortSignal from "ext:deno_web/03_abort_signal.js";
-
+import {
+ createDependentAbortSignal,
+ newSignal,
+ signalAbort,
+} from "ext:deno_web/03_abort_signal.js";
+import { DOMException } from "ext:deno_web/01_dom_exception.js";
const { internalRidSymbol } = core;
const _request = Symbol("request");
@@ -52,6 +56,7 @@ const _headers = Symbol("headers");
const _getHeaders = Symbol("get headers");
const _headersCache = Symbol("headers cache");
const _signal = Symbol("signal");
+const _signalCache = Symbol("signalCache");
const _mimeType = Symbol("mime type");
const _body = Symbol("body");
const _url = Symbol("url");
@@ -262,7 +267,13 @@ class Request {
}
/** @type {AbortSignal} */
- [_signal];
+ get [_signal]() {
+ const signal = this[_signalCache];
+ if (signal !== undefined) {
+ return signal;
+ }
+ return (this[_signalCache] = newSignal());
+ }
get [_mimeType]() {
const values = getDecodeSplitHeader(
headerListFromHeaders(this[_headers]),
@@ -363,11 +374,10 @@ class Request {
// 28.
this[_request] = request;
- // 29.
- const signals = signal !== null ? [signal] : [];
-
- // 30.
- this[_signal] = abortSignal.createDependentAbortSignal(signals, prefix);
+ // 29 & 30.
+ if (signal !== null) {
+ this[_signalCache] = createDependentAbortSignal([signal], prefix);
+ }
// 31.
this[_headers] = headersFromHeaderList(request.headerList, "request");
@@ -473,17 +483,21 @@ class Request {
}
const clonedReq = cloneInnerRequest(this[_request]);
- assert(this[_signal] !== null);
- const clonedSignal = abortSignal.createDependentAbortSignal(
- [this[_signal]],
+ const materializedSignal = this[_signal];
+ const clonedSignal = createDependentAbortSignal(
+ [materializedSignal],
prefix,
);
- return fromInnerRequest(
- clonedReq,
- clonedSignal,
- guardFromHeaders(this[_headers]),
- );
+ const request = new Request(_brand);
+ request[_request] = clonedReq;
+ request[_signalCache] = clonedSignal;
+ request[_getHeaders] = () =>
+ headersFromHeaderList(
+ clonedReq.headerList,
+ guardFromHeaders(this[_headers]),
+ );
+ return request;
}
[SymbolFor("Deno.privateCustomInspect")](inspect, inspectOptions) {
@@ -562,19 +576,30 @@ function toInnerRequest(request) {
/**
* @param {InnerRequest} inner
- * @param {AbortSignal} signal
* @param {"request" | "immutable" | "request-no-cors" | "response" | "none"} guard
* @returns {Request}
*/
-function fromInnerRequest(inner, signal, guard) {
+function fromInnerRequest(inner, guard) {
const request = new Request(_brand);
request[_request] = inner;
- request[_signal] = signal;
request[_getHeaders] = () => headersFromHeaderList(inner.headerList, guard);
return request;
}
+const signalAbortError = new DOMException(
+ "The request has been cancelled.",
+ "AbortError",
+);
+ObjectFreeze(signalAbortError);
+
+function abortRequest(request) {
+ if (request[_signal]) {
+ request[_signal][signalAbort](signalAbortError);
+ }
+}
+
export {
+ abortRequest,
fromInnerRequest,
newInnerRequest,
processUrlList,