diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-09-20 20:59:05 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-20 20:59:05 +0530 |
| commit | 92fc702cec555a08c38509bfb10edd3d163af241 (patch) | |
| tree | 031e645809c88f1f85b643168487056cd8aec851 /ext/crypto/shared.rs | |
| parent | 471a15ecfffff009d24a684dda47a42aa71001d7 (diff) | |
fix(ext/crypto): ensure EC public keys are exported uncompressed (#25766)
Fixes https://github.com/denoland/deno/issues/18050
Diffstat (limited to 'ext/crypto/shared.rs')
| -rw-r--r-- | ext/crypto/shared.rs | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/ext/crypto/shared.rs b/ext/crypto/shared.rs index 21fddc745..d5b2d6593 100644 --- a/ext/crypto/shared.rs +++ b/ext/crypto/shared.rs @@ -98,11 +98,9 @@ impl V8RawKeyData { pub fn as_ec_public_key_p256(&self) -> Result<p256::EncodedPoint, AnyError> { match self { - V8RawKeyData::Public(data) => { - // public_key is a serialized EncodedPoint - p256::EncodedPoint::from_bytes(data) - .map_err(|_| type_error("expected valid public EC key")) - } + V8RawKeyData::Public(data) => p256::PublicKey::from_sec1_bytes(data) + .map(|p| p.to_encoded_point(false)) + .map_err(|_| type_error("expected valid public EC key")), V8RawKeyData::Private(data) => { let signing_key = p256::SecretKey::from_pkcs8_der(data) .map_err(|_| type_error("expected valid private EC key"))?; @@ -115,11 +113,9 @@ impl V8RawKeyData { pub fn as_ec_public_key_p384(&self) -> Result<p384::EncodedPoint, AnyError> { match self { - V8RawKeyData::Public(data) => { - // public_key is a serialized EncodedPoint - p384::EncodedPoint::from_bytes(data) - .map_err(|_| type_error("expected valid public EC key")) - } + V8RawKeyData::Public(data) => p384::PublicKey::from_sec1_bytes(data) + .map(|p| p.to_encoded_point(false)) + .map_err(|_| type_error("expected valid public EC key")), V8RawKeyData::Private(data) => { let signing_key = p384::SecretKey::from_pkcs8_der(data) .map_err(|_| type_error("expected valid private EC key"))?; |