diff options
author | Aaron O'Mullan <aaron.omullan@gmail.com> | 2022-05-15 13:27:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-15 13:27:56 +0200 |
commit | f5c31b56e3fb57a92dbaaec17690bfa9d787164e (patch) | |
tree | 4b9cd72ed81d16430734240e2a57bcf1739334fe /core/runtime.rs | |
parent | b08b1da6f4550601eec23327bd40d17ad6a6b4e9 (diff) |
Revert "core: don't include_str extension js code (#10786)" (#14614)
This reverts commit 10e50a120744de71d6915af4ae93f8231607573d
Alternative to #13217, IMO the tradeoffs made by #10786 aren't worth it.
It breaks abstractions (crates being self-contained, deno_core without snapshotting etc...) and causes pain points / gotchas for both embedders & devs for a relatively minimal gain in incremental build time ...
Closes #11030
Diffstat (limited to 'core/runtime.rs')
-rw-r--r-- | core/runtime.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/core/runtime.rs b/core/runtime.rs index f589ad25b..f8afeb76c 100644 --- a/core/runtime.rs +++ b/core/runtime.rs @@ -491,9 +491,8 @@ impl JsRuntime { for m in extensions.iter_mut() { let js_files = m.init_js(); for (filename, source) in js_files { - let source = source()?; // TODO(@AaronO): use JsRuntime::execute_static() here to move src off heap - realm.execute_script(self, filename, &source)?; + realm.execute_script(self, filename, source)?; } } // Restore extensions |