summaryrefslogtreecommitdiff
path: root/core/runtime.rs
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2023-03-07 17:37:37 -0400
committerGitHub <noreply@github.com>2023-03-07 22:37:37 +0100
commitb32a6f8ad20e6e4b0cc24b8256c08192b4899844 (patch)
tree76201de6fe376b658b99228c8d2ca1618181ee57 /core/runtime.rs
parent0e3affcd5b932e1b1ecc37934a0625a0d4d0d62c (diff)
refactor(core): don't use Result in ExtensionBuilder::state (#18066)
There's no point for this API to expect result. If something fails it should result in a panic during build time to signal to embedder that setup is wrong.
Diffstat (limited to 'core/runtime.rs')
-rw-r--r--core/runtime.rs6
1 files changed, 2 insertions, 4 deletions
diff --git a/core/runtime.rs b/core/runtime.rs
index 1d74c9ede..92e23873a 100644
--- a/core/runtime.rs
+++ b/core/runtime.rs
@@ -939,7 +939,7 @@ impl JsRuntime {
// Setup state
for e in extensions.iter_mut() {
// ops are already registered during in bindings::initialize_context();
- e.init_state(&mut op_state.borrow_mut())?;
+ e.init_state(&mut op_state.borrow_mut());
// Setup event-loop middleware
if let Some(middleware) = e.init_event_loop_middleware() {
@@ -957,7 +957,7 @@ impl JsRuntime {
// Setup state
for e in extensions.iter_mut() {
// ops are already registered during in bindings::initialize_context();
- e.init_state(&mut op_state.borrow_mut())?;
+ e.init_state(&mut op_state.borrow_mut());
// Setup event-loop middleware
if let Some(middleware) = e.init_event_loop_middleware() {
@@ -2887,7 +2887,6 @@ pub mod tests {
mode,
dispatch_count: dispatch_count2.clone(),
});
- Ok(())
})
.build();
let mut runtime = JsRuntime::new(RuntimeOptions {
@@ -4045,7 +4044,6 @@ assertEquals(1, notify_return_value);
.ops(vec![op_async_borrow::decl()])
.state(|state| {
state.put(InnerState(42));
- Ok(())
})
.build();