summaryrefslogtreecommitdiff
path: root/core/runtime.rs
diff options
context:
space:
mode:
authorNayeem Rahman <nayeemrmn99@gmail.com>2021-02-18 22:36:02 +0000
committerGitHub <noreply@github.com>2021-02-19 09:36:02 +1100
commit555595e6d02d1fc1adb535df074d258389fab509 (patch)
tree73257523ea5f5ac44293b6820d72e8dae038b7b5 /core/runtime.rs
parentbb30e9291e2e3964aac2d2ca05b739dcc67d64a0 (diff)
fix(core): Make dynamic import async errors catchable (#9505)
Fixes #6259
Diffstat (limited to 'core/runtime.rs')
-rw-r--r--core/runtime.rs6
1 files changed, 6 insertions, 0 deletions
diff --git a/core/runtime.rs b/core/runtime.rs
index 31229aaa3..35f9e7e43 100644
--- a/core/runtime.rs
+++ b/core/runtime.rs
@@ -822,6 +822,12 @@ impl JsRuntime {
);
let promise = v8::Local::<v8::Promise>::try_from(value)
.expect("Expected to get promise as module evaluation result");
+ let empty_fn = |_scope: &mut v8::HandleScope,
+ _args: v8::FunctionCallbackArguments,
+ _rv: v8::ReturnValue| {};
+ let empty_fn = v8::FunctionTemplate::new(scope, empty_fn);
+ let empty_fn = empty_fn.get_function(scope).unwrap();
+ promise.catch(scope, empty_fn);
let promise_global = v8::Global::new(scope, promise);
let mut state = state_rc.borrow_mut();
state.pending_promise_exceptions.remove(&promise_global);