summaryrefslogtreecommitdiff
path: root/core/ops.rs
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2021-11-25 19:49:09 +0100
committerGitHub <noreply@github.com>2021-11-25 19:49:09 +0100
commitf3c0f0565bbf43b4cc31979b05e729d4f4a1538f (patch)
tree6554dfdecd89e076166531b91824d6750d5b76e0 /core/ops.rs
parent2853e3760471560c1812b46007e1a525966b1365 (diff)
feat(core): Add ability to "ref" and "unref" pending ops (#12889)
This commit adds an ability to "ref" or "unref" pending ops. Up to this point Deno had a notion of "async ops" and "unref async ops"; the former keep event loop alive, while the latter do not block event loop from finishing. It was not possible to change between op types after dispatching, one had to decide which type to use before dispatch. Instead of storing ops in two separate "FuturesUnordered" collections, now ops are stored in a single collection, with supplemental "HashSet" storing ids of promises that were "unrefed". Two APIs were added to "Deno.core": "Deno.core.refOp(promiseId)" which allows to mark promise id to be "refed" and keep event loop alive (the default behavior) "Deno.core.unrefOp(promiseId)" which allows to mark promise id as "unrefed" which won't block event loop from exiting
Diffstat (limited to 'core/ops.rs')
-rw-r--r--core/ops.rs5
1 files changed, 1 insertions, 4 deletions
diff --git a/core/ops.rs b/core/ops.rs
index 13f001146..6b2c06397 100644
--- a/core/ops.rs
+++ b/core/ops.rs
@@ -80,7 +80,7 @@ where
}
}
-pub type PromiseId = u64;
+pub type PromiseId = i32;
pub type OpAsyncFuture = OpCall<(PromiseId, OpId, OpResult)>;
pub type OpFn = dyn Fn(Rc<RefCell<OpState>>, OpPayload) -> Op + 'static;
pub type OpId = usize;
@@ -111,9 +111,6 @@ impl<'a, 'b, 'c> OpPayload<'a, 'b, 'c> {
pub enum Op {
Sync(OpResult),
Async(OpAsyncFuture),
- /// AsyncUnref is the variation of Async, which doesn't block the program
- /// exiting.
- AsyncUnref(OpAsyncFuture),
NotFound,
}