summaryrefslogtreecommitdiff
path: root/core/modules.rs
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2021-07-30 13:36:43 +0200
committerGitHub <noreply@github.com>2021-07-30 13:36:43 +0200
commitc909faf9e6cd2964398da7c0852d0229cdd1a22b (patch)
tree033eb0e7edf86f120b9d96a8f591586d5b46e203 /core/modules.rs
parent2b13bb694532904704c16bec4e8a47c386e681e2 (diff)
chore(core): use oneshot channel in mod_evaluate() (#11556)
Oneshot is more appropriate because mod_evaluate() only sends a single value. It also makes it easier to use it correctly. As an embedder, I wasn't sure if I'm expected to drain the channel or not.
Diffstat (limited to 'core/modules.rs')
-rw-r--r--core/modules.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/core/modules.rs b/core/modules.rs
index 765536107..3c8976c84 100644
--- a/core/modules.rs
+++ b/core/modules.rs
@@ -906,7 +906,7 @@ mod tests {
let a_id_fut = runtime.load_module(&spec, None);
let a_id = futures::executor::block_on(a_id_fut).expect("Failed to load");
- runtime.mod_evaluate(a_id);
+ let _ = runtime.mod_evaluate(a_id);
futures::executor::block_on(runtime.run_event_loop(false)).unwrap();
let l = loads.lock();
assert_eq!(
@@ -1076,7 +1076,7 @@ mod tests {
runtime.instantiate_module(mod_a).unwrap();
assert_eq!(dispatch_count.load(Ordering::Relaxed), 0);
- runtime.mod_evaluate(mod_a);
+ let _ = runtime.mod_evaluate(mod_a);
assert_eq!(dispatch_count.load(Ordering::Relaxed), 1);
}
@@ -1366,7 +1366,7 @@ mod tests {
let result = runtime.load_module(&spec, None).await;
assert!(result.is_ok());
let circular1_id = result.unwrap();
- runtime.mod_evaluate(circular1_id);
+ let _ = runtime.mod_evaluate(circular1_id);
runtime.run_event_loop(false).await.unwrap();
let l = loads.lock();
@@ -1439,7 +1439,7 @@ mod tests {
println!(">> result {:?}", result);
assert!(result.is_ok());
let redirect1_id = result.unwrap();
- runtime.mod_evaluate(redirect1_id);
+ let _ = runtime.mod_evaluate(redirect1_id);
runtime.run_event_loop(false).await.unwrap();
let l = loads.lock();
assert_eq!(
@@ -1588,7 +1588,7 @@ mod tests {
let main_id =
futures::executor::block_on(main_id_fut).expect("Failed to load");
- runtime.mod_evaluate(main_id);
+ let _ = runtime.mod_evaluate(main_id);
futures::executor::block_on(runtime.run_event_loop(false)).unwrap();
let l = loads.lock();