diff options
| author | Bert Belder <bertbelder@gmail.com> | 2019-04-28 21:31:10 +0200 |
|---|---|---|
| committer | Bert Belder <bertbelder@gmail.com> | 2019-05-01 21:11:09 +0200 |
| commit | 41c7e96f1a81ea416ebb3ba45f2815e0202d6b75 (patch) | |
| tree | 5fcb15b8664d7579cf4db76d16754c8efa7c4667 /core/libdeno/BUILD.gn | |
| parent | abdb98a2516a9d6ec313805dffbc2107d38f8ed4 (diff) | |
Refactor zero-copy buffers for performance and to prevent memory leaks
* In order to prevent ArrayBuffers from getting garbage collected by V8,
we used to store a v8::Persistent<ArrayBuffer> in a map. This patch
introduces a custom ArrayBuffer allocator which doesn't use Persistent
handles, but instead stores a pointer to the actual ArrayBuffer data
alongside with a reference count. Since creating Persistent handles
has quite a bit of overhead, this change significantly increases
performance. Various HTTP server benchmarks report about 5-10% more
requests per second than before.
* Previously the Persistent handle that prevented garbage collection had
to be released manually, and this wasn't always done, which was
causing memory leaks. This has been resolved by introducing a new
`PinnedBuf` type in both Rust and C++ that automatically re-enables
garbage collection when it goes out of scope.
* Zero-copy buffers are now correctly wrapped in an Option if there is a
possibility that they're not present. This clears up a correctness
issue where we were creating zero-length slices from a null pointer,
which is against the rules.
Diffstat (limited to 'core/libdeno/BUILD.gn')
| -rw-r--r-- | core/libdeno/BUILD.gn | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/core/libdeno/BUILD.gn b/core/libdeno/BUILD.gn index 8ad3dccc3..31a5be640 100644 --- a/core/libdeno/BUILD.gn +++ b/core/libdeno/BUILD.gn @@ -46,6 +46,7 @@ v8_source_set("libdeno") { sources = [ "api.cc", "binding.cc", + "buffer.h", "deno.h", "exceptions.cc", "exceptions.h", |