diff options
| author | Nayeem Rahman <nayeemrmn99@gmail.com> | 2023-06-13 16:45:06 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-13 09:45:06 -0600 |
| commit | ceb03cfb037cf7024a5048b17b508ddda59cfa05 (patch) | |
| tree | 0c2df444e00f17131f9e2af708f80cdc4b032ce8 /core/lib.rs | |
| parent | 5348778666d2d8d7ce138bbdf75ac5aa9f7ed428 (diff) | |
refactor(core): cleanup feature flags for js source inclusion (#19463)
Remove `ExtensionFileSourceCode::LoadedFromFsDuringSnapshot` and feature
`include_js_for_snapshotting` since they leak paths that are only
applicable in this repo to embedders. Replace with feature
`exclude_js_sources`. Additionally the feature
`force_include_js_sources` allows negating it, if both features are set.
We need both of these because features are additive and there must be a
way of force including sources for snapshot creation while still having
the `exclude_js_sources` feature. `force_include_js_sources` is only set
for build deps, so sources are still excluded from the final binary.
You can also specify `force_include_js_sources` on any extension to
override the above features for that extension. Towards #19398.
But there was still the snapshot-from-snapshot situation where code
could be executed twice, I addressed that by making `mod_evaluate()` and
scripts like `core/01_core.js` behave idempotently. This allowed
unifying `ext::init_ops()` and `ext::init_ops_and_esm()` into
`ext::init()`.
Diffstat (limited to 'core/lib.rs')
| -rw-r--r-- | core/lib.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/core/lib.rs b/core/lib.rs index 336d9c2b9..729182a4f 100644 --- a/core/lib.rs +++ b/core/lib.rs @@ -60,7 +60,6 @@ pub use crate::async_cell::RcRef; pub use crate::extensions::Extension; pub use crate::extensions::ExtensionBuilder; pub use crate::extensions::ExtensionFileSource; -pub use crate::extensions::ExtensionFileSourceCode; pub use crate::extensions::OpDecl; pub use crate::extensions::OpMiddlewareFn; pub use crate::fast_string::FastString; |