diff options
author | Ryan Dahl <ry@tinyclouds.org> | 2020-02-03 18:08:44 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-02-03 18:08:44 -0500 |
commit | 161cf7cdfd44ace8937fb7940727984990742d18 (patch) | |
tree | 1ef88b3cd6427353366d930ea9be5ae494504255 /core/isolate.rs | |
parent | 0471243334ac1aeb76dcaadbc3f0b8114d188fb8 (diff) |
refactor: Use Tokio's single-threaded runtime (#3844)
This change simplifies how we execute V8. Previously V8 Isolates jumped
around threads every time they were woken up. This was overly complex and
potentially hurting performance in a myriad ways. Now isolates run on
their own dedicated thread and never move.
- blocking_json spawns a thread and does not use a thread pool
- op_host_poll_worker and op_host_resume_worker are non-operational
- removes Worker::get_message and Worker::post_message
- ThreadSafeState::workers table contains WorkerChannel entries instead
of actual Worker instances.
- MainWorker and CompilerWorker are no longer Futures.
- The multi-threaded version of deno_core_http_bench was removed.
- AyncOps no longer need to be Send + Sync
This PR is very large and several tests were disabled to speed
integration:
- installer_test_local_module_run
- installer_test_remote_module_run
- _015_duplicate_parallel_import
- _026_workers
Diffstat (limited to 'core/isolate.rs')
-rw-r--r-- | core/isolate.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/core/isolate.rs b/core/isolate.rs index 3be90193c..55ba52d5c 100644 --- a/core/isolate.rs +++ b/core/isolate.rs @@ -20,12 +20,12 @@ use futures::stream::select; use futures::stream::FuturesUnordered; use futures::stream::StreamExt; use futures::task::AtomicWaker; +use futures::Future; use libc::c_void; use std::collections::HashMap; use std::convert::From; use std::error::Error; use std::fmt; -use std::future::Future; use std::ops::{Deref, DerefMut}; use std::option::Option; use std::pin::Pin; @@ -180,6 +180,7 @@ pub struct Isolate { error_handler: Option<Box<IsolateErrorHandleFn>>, } +// TODO(ry) this shouldn't be necessary, v8::OwnedIsolate should impl Send. unsafe impl Send for Isolate {} impl Drop for Isolate { @@ -423,7 +424,7 @@ impl Isolate { /// Requires runtime to explicitly ask for op ids before using any of the ops. pub fn register_op<F>(&self, name: &str, op: F) -> OpId where - F: Fn(&[u8], Option<ZeroCopyBuf>) -> CoreOp + Send + Sync + 'static, + F: Fn(&[u8], Option<ZeroCopyBuf>) -> CoreOp + 'static, { self.op_registry.register(name, op) } @@ -489,13 +490,13 @@ impl Isolate { } Op::Async(fut) => { let fut2 = fut.map_ok(move |buf| (op_id, buf)); - self.pending_ops.push(fut2.boxed()); + self.pending_ops.push(fut2.boxed_local()); self.have_unpolled_ops = true; None } Op::AsyncUnref(fut) => { let fut2 = fut.map_ok(move |buf| (op_id, buf)); - self.pending_unref_ops.push(fut2.boxed()); + self.pending_unref_ops.push(fut2.boxed_local()); self.have_unpolled_ops = true; None } |