diff options
| author | Matt Mastracci <matthew@mastracci.com> | 2023-04-04 06:46:31 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-04 06:46:31 -0600 |
| commit | a1764f7690cfdc3e42724fcad29ef954b7e576a4 (patch) | |
| tree | 1b621ebd7a6ef50687eeb2061740895096136e8a /core/examples/http_bench_json_ops/main.rs | |
| parent | 2dc20168371e827b86e2ce0d1d7787139fba68f3 (diff) | |
refactor(core): Improve ergonomics of managing ASCII strings (#18498)
This is a follow-on to the earlier work in reducing string copies,
mainly focused on ensuring that ASCII strings are easy to provide to the
JS runtime.
While we are replacing a 16-byte reference in a number of places with a
24-byte structure (measured via `std::mem::size_of`), the reduction in
copies wins out over the additional size of the arguments passed into
functions.
Benchmarking shows approximately the same if not slightly less wallclock
time/instructions retired, but I believe this continues to open up
further refactoring opportunities.
Diffstat (limited to 'core/examples/http_bench_json_ops/main.rs')
| -rw-r--r-- | core/examples/http_bench_json_ops/main.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/examples/http_bench_json_ops/main.rs b/core/examples/http_bench_json_ops/main.rs index f0bbec0d9..7c15f7bf2 100644 --- a/core/examples/http_bench_json_ops/main.rs +++ b/core/examples/http_bench_json_ops/main.rs @@ -165,7 +165,7 @@ fn main() { js_runtime .execute_script( "http_bench_json_ops.js", - include_str!("http_bench_json_ops.js"), + include_ascii_string!("http_bench_json_ops.js"), ) .unwrap(); js_runtime.run_event_loop(false).await |