diff options
author | Divy Srivastava <dj.srivastava23@gmail.com> | 2023-03-31 21:28:21 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-31 21:28:21 +0530 |
commit | aa9b94a80eadde7737417eb7d412559bc567c77c (patch) | |
tree | 14691957c663ad9d6c18ce837823f46e4ddc4347 /core/01_core.js | |
parent | feab94ff512987a9a7e01f41d7a1788712b4247c (diff) |
perf(ext/websocket): use opAsync2 to avoid spread deopt (#18525)
This commit adds a new core API `opAsync2` to call an async op with
atmost 2 arguments. Spread argument iterators has a pretty big perf hit
when calling ops.
| name | avg msg/sec/core |
| --- | --- |
| 1.32.1 | `127820.750000` |
| #18506 | `140079.000000` |
| #18506 + #18509 | `150104.250000` |
| #18506 + #18509 + this | `157340.000000` |
Diffstat (limited to 'core/01_core.js')
-rw-r--r-- | core/01_core.js | 19 |
1 files changed, 16 insertions, 3 deletions
diff --git a/core/01_core.js b/core/01_core.js index a13bdc8dd..c46c30070 100644 --- a/core/01_core.js +++ b/core/01_core.js @@ -191,12 +191,24 @@ return res; } - function rollPromiseId() { - return nextPromiseId++; + function opAsync2(name, arg0, arg1) { + const id = nextPromiseId++; + let promise = PromisePrototypeThen(setPromise(id), unwrapOpResult); + try { + ops[name](id, arg0, arg1); + } catch (err) { + // Cleanup the just-created promise + getPromise(id); + // Rethrow the error + throw err; + } + promise = handleOpCallTracing(name, id, promise); + promise[promiseIdSymbol] = id; + return promise; } function opAsync(name, ...args) { - const id = rollPromiseId(); + const id = nextPromiseId++; let promise = PromisePrototypeThen(setPromise(id), unwrapOpResult); try { ops[name](id, ...new SafeArrayIterator(args)); @@ -376,6 +388,7 @@ // Extra Deno.core.* exports const core = ObjectAssign(globalThis.Deno.core, { opAsync, + opAsync2, resources, metrics, registerErrorBuilder, |