diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2022-12-01 21:29:15 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-02 05:29:15 +0000 |
| commit | 9b2b8df927ac23cfa99016a684179f2a3198ba2e (patch) | |
| tree | 1d13b575bc7c4f7279b2ff3fdde175a7522d643a /cli | |
| parent | 075854e5162c3d9f4fd7061d19acbe2c5855536e (diff) | |
feat(ops): Fast zero copy string arguments (#16777)
Uses SeqOneByteString optimization to do zero-copy `&str` arguments in
fast calls.
- [x] Depends on https://github.com/denoland/rusty_v8/pull/1129
- [x] Depends on
https://chromium-review.googlesource.com/c/v8/v8/+/4036884
- [x] Disable in async ops
- [x] Make it work with owned `String` with an extra alloc in fast path.
- [x] Support `Cow<'_, str>`. Owned for slow case, Borrowed for fast
case
```rust
#[op]
fn op_string_len(s: &str) -> u32 {
str.len() as u32
}
```
Diffstat (limited to 'cli')
| -rw-r--r-- | cli/bench/console.js | 5 | ||||
| -rw-r--r-- | cli/bench/encode_into.js | 5 | ||||
| -rw-r--r-- | cli/bench/webstorage.js | 21 | ||||
| -rw-r--r-- | cli/tsc/mod.rs | 4 |
4 files changed, 25 insertions, 10 deletions
diff --git a/cli/bench/console.js b/cli/bench/console.js index b1873953c..1e0ebb37a 100644 --- a/cli/bench/console.js +++ b/cli/bench/console.js @@ -1,8 +1,3 @@ // Copyright 2018-2022 the Deno authors. All rights reserved. MIT license. const count = 100000; - -const start = Date.now(); for (let i = 0; i < count; i++) console.log("Hello World"); -const elapsed = Date.now() - start; -const rate = Math.floor(count / (elapsed / 1000)); -console.log(`time ${elapsed} ms rate ${rate}`); diff --git a/cli/bench/encode_into.js b/cli/bench/encode_into.js index aaee23434..458a88b84 100644 --- a/cli/bench/encode_into.js +++ b/cli/bench/encode_into.js @@ -1,11 +1,10 @@ // Copyright 2018-2022 the Deno authors. All rights reserved. MIT license. -const queueMicrotask = globalThis.queueMicrotask || process.nextTick; let [total, count] = typeof Deno !== "undefined" ? Deno.args : [process.argv[2], process.argv[3]]; total = total ? parseInt(total, 0) : 50; -count = count ? parseInt(count, 10) : 1000000; +count = count ? parseInt(count, 10) : 10000000; function bench(fun) { const start = Date.now(); @@ -13,7 +12,7 @@ function bench(fun) { const elapsed = Date.now() - start; const rate = Math.floor(count / (elapsed / 1000)); console.log(`time ${elapsed} ms rate ${rate}`); - if (--total) queueMicrotask(() => bench(fun)); + if (--total) bench(fun); } const encoder = new TextEncoder(); diff --git a/cli/bench/webstorage.js b/cli/bench/webstorage.js new file mode 100644 index 000000000..bdb10e568 --- /dev/null +++ b/cli/bench/webstorage.js @@ -0,0 +1,21 @@ +// Copyright 2018-2022 the Deno authors. All rights reserved. MIT license. + +// Note: when benchmarking across different Deno version, make sure to clear +// the DENO_DIR cache. +let [total, count] = typeof Deno !== "undefined" ? Deno.args : []; + +total = total ? parseInt(total, 0) : 50; +count = count ? parseInt(count, 10) : 1000000; + +function bench(fun) { + const start = Date.now(); + for (let i = 0; i < count; i++) fun(i); + const elapsed = Date.now() - start; + const rate = Math.floor(count / (elapsed / 1000)); + console.log(`time ${elapsed} ms rate ${rate}`); + if (--total) queueMicrotask(() => bench(fun)); +} + +localStorage.clear(); +localStorage.setItem("foo", "bar"); +bench(() => localStorage.getItem("foo")); diff --git a/cli/tsc/mod.rs b/cli/tsc/mod.rs index a8eb15c19..1fb4d32d3 100644 --- a/cli/tsc/mod.rs +++ b/cli/tsc/mod.rs @@ -683,9 +683,9 @@ pub fn resolve_npm_package_reference_types( } #[op] -fn op_is_node_file(state: &mut OpState, path: String) -> bool { +fn op_is_node_file(state: &mut OpState, path: &str) -> bool { let state = state.borrow::<State>(); - match ModuleSpecifier::parse(&path) { + match ModuleSpecifier::parse(path) { Ok(specifier) => state .maybe_npm_resolver .as_ref() |
