diff options
| author | Nayeem Rahman <nayeemrmn99@gmail.com> | 2023-05-04 01:44:59 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-04 02:44:59 +0200 |
| commit | 7a8bb3b611f02b272b1c19b6f3d8a85b099ca317 (patch) | |
| tree | 04d37bb0f8c3fc719b3494114a054f5439733e7a /cli | |
| parent | e3276fbb71093faf4e8850f68ed2e080a9bda222 (diff) | |
fix(core): allow esm extensions not included in snapshot (#18980)
Fixes #18979.
This changes the predicate for allowing `ext:` specifier resolution from
`snapshot_loaded_and_not_snapshotting` to `ext_resolution_allowed` which
is only set to true during the extension module loading phase. Module
loaders as used in core
are now declared as `ExtModuleLoader` rather than `dyn ModuleLoader`.
Diffstat (limited to 'cli')
| -rw-r--r-- | cli/tests/testdata/run/extension_dynamic_import.ts.out | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cli/tests/testdata/run/extension_dynamic_import.ts.out b/cli/tests/testdata/run/extension_dynamic_import.ts.out index 18b05ea47..081318960 100644 --- a/cli/tests/testdata/run/extension_dynamic_import.ts.out +++ b/cli/tests/testdata/run/extension_dynamic_import.ts.out @@ -1,4 +1,4 @@ -error: Uncaught TypeError: Cannot load extension module from external code +error: Uncaught (in promise) TypeError: Cannot load extension module from external code await import("ext:runtime/01_errors.js"); ^ at [WILDCARD]/extension_dynamic_import.ts:1:1 |