fix(ext/node): improve vm.runInThisContext (#18767)

2 files changed, 76 insertions, 0 deletions

diff --git a/cli/tests/node_compat/config.jsonc b/cli/tests/node_compat/config.jsonc
index b22d252e4..ddbdf458f 100644
--- a/cli/tests/node_compat/config.jsonc
+++ b/cli/tests/node_compat/config.jsonc
@@ -624,6 +624,7 @@
       "test-util-types-exists.js",
       "test-util-types.js",
       "test-util.js",
+      "test-vm-new-script-this-context.js",
       "test-vm-static-this.js",
       "test-webcrypto-sign-verify.js",
       "test-whatwg-encoding-custom-api-basics.js",
diff --git a/cli/tests/node_compat/test/parallel/test-vm-new-script-this-context.js b/cli/tests/node_compat/test/parallel/test-vm-new-script-this-context.js
new file mode 100644
index 000000000..f6a68aef9
--- /dev/null
+++ b/cli/tests/node_compat/test/parallel/test-vm-new-script-this-context.js
@@ -0,0 +1,75 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 18.12.1
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const Script = require('vm').Script;
+
+// Run a string
+let script = new Script('\'passed\';');
+const result = script.runInThisContext(script);
+assert.strictEqual(result, 'passed');
+
+// Thrown error
+script = new Script('throw new Error(\'test\');');
+assert.throws(() => {
+  script.runInThisContext(script);
+}, /^Error: test$/);
+
+global.hello = 5;
+script = new Script('hello = 2');
+script.runInThisContext(script);
+assert.strictEqual(global.hello, 2);
+
+
+// Pass values
+global.code = 'foo = 1;' +
+              'bar = 2;' +
+              'if (typeof baz !== "undefined") throw new Error("test fail");';
+global.foo = 2;
+global.obj = { foo: 0, baz: 3 };
+script = new Script(global.code);
+script.runInThisContext(script);
+assert.strictEqual(global.obj.foo, 0);
+assert.strictEqual(global.bar, 2);
+assert.strictEqual(global.foo, 1);
+
+// Call a function
+global.f = function() { global.foo = 100; };
+script = new Script('f()');
+script.runInThisContext(script);
+assert.strictEqual(global.foo, 100);
+
+common.allowGlobals(
+  global.hello,
+  global.code,
+  global.foo,
+  global.obj,
+  global.f
+);