diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2024-09-18 14:49:30 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-18 14:49:30 +0100 |
| commit | 48ea4e3c92b53936e89101a56a013300a47337d3 (patch) | |
| tree | 90ca1009d8eb29796fab0654028043b5db0628fe /cli | |
| parent | 7533492a7817ba61b3606dd412b78dc4d98faa76 (diff) | |
feat(check): turn on noImplicitOverride (#25695)
Closes https://github.com/denoland/deno/issues/11836
Ref https://github.com/denoland/deno/issues/25162
Diffstat (limited to 'cli')
| -rw-r--r-- | cli/Cargo.toml | 2 | ||||
| -rw-r--r-- | cli/lsp/config.rs | 1 | ||||
| -rw-r--r-- | cli/schemas/config-file.v1.json | 2 | ||||
| -rw-r--r-- | cli/tsc/99_main_compiler.js | 1 |
4 files changed, 4 insertions, 2 deletions
diff --git a/cli/Cargo.toml b/cli/Cargo.toml index 40e3844c2..057b601ff 100644 --- a/cli/Cargo.toml +++ b/cli/Cargo.toml @@ -65,7 +65,7 @@ winres.workspace = true [dependencies] deno_ast = { workspace = true, features = ["bundler", "cjs", "codegen", "proposal", "react", "sourcemap", "transforms", "typescript", "view", "visit"] } deno_cache_dir = { workspace = true } -deno_config = { version = "=0.34.2", features = ["workspace", "sync"] } +deno_config = { version = "=0.34.3", features = ["workspace", "sync"] } deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] } deno_doc = { version = "0.148.0", features = ["html", "syntect"] } deno_graph = { version = "=0.82.1" } diff --git a/cli/lsp/config.rs b/cli/lsp/config.rs index f69cae435..94fdff167 100644 --- a/cli/lsp/config.rs +++ b/cli/lsp/config.rs @@ -1129,6 +1129,7 @@ impl Default for LspTsConfig { "module": "esnext", "moduleDetection": "force", "noEmit": true, + "noImplicitOverride": true, "resolveJsonModule": true, "strict": true, "target": "esnext", diff --git a/cli/schemas/config-file.v1.json b/cli/schemas/config-file.v1.json index 8d0af55bf..96b7c4bed 100644 --- a/cli/schemas/config-file.v1.json +++ b/cli/schemas/config-file.v1.json @@ -127,7 +127,7 @@ "noImplicitOverride": { "description": "Ensure overriding members in derived classes are marked with an override modifier.", "type": "boolean", - "default": false, + "default": true, "markdownDescription": "Ensure overriding members in derived classes are marked with an override modifier.\n\nSee more: https://www.typescriptlang.org/tsconfig#noImplicitOverride" }, "noImplicitReturns": { diff --git a/cli/tsc/99_main_compiler.js b/cli/tsc/99_main_compiler.js index c5769168f..719f2b982 100644 --- a/cli/tsc/99_main_compiler.js +++ b/cli/tsc/99_main_compiler.js @@ -1154,6 +1154,7 @@ delete Object.prototype.__proto__; "moduleResolution": "NodeNext", "moduleDetection": "force", "noEmit": true, + "noImplicitOverride": true, "resolveJsonModule": true, "strict": true, "target": "esnext", |