refactor: make version and user_agent &'static str (#18400)

These caused a bunch of unnecessary allocations on each startup.

1 files changed, 24 insertions, 9 deletions

diff --git a/cli/version.rs b/cli/version.rs
index 88dc9ffc7..f13baa1f2 100644
--- a/cli/version.rs
+++ b/cli/version.rs
@@ -3,11 +3,30 @@
 pub const GIT_COMMIT_HASH: &str = env!("GIT_COMMIT_HASH");
 pub const TYPESCRIPT: &str = env!("TS_VERSION");
 
-pub fn deno() -> String {
-  let version = env!("CARGO_PKG_VERSION");
-  option_env!("DENO_CANARY")
-    .map(|_| format!("{}+{}", version, &GIT_COMMIT_HASH[..7]))
-    .unwrap_or_else(|| version.to_string())
+pub fn deno() -> &'static str {
+  if is_canary() {
+    concat!(
+      env!("CARGO_PKG_VERSION"),
+      "+",
+      env!("GIT_COMMIT_HASH_SHORT")
+    )
+  } else {
+    env!("CARGO_PKG_VERSION")
+  }
+}
+
+// Keep this in sync with `deno()` above
+pub fn get_user_agent() -> &'static str {
+  if is_canary() {
+    concat!(
+      "Deno/",
+      env!("CARGO_PKG_VERSION"),
+      "+",
+      env!("GIT_COMMIT_HASH_SHORT")
+    )
+  } else {
+    concat!("Deno/", env!("CARGO_PKG_VERSION"))
+  }
 }
 
 pub fn is_canary() -> bool {
@@ -21,7 +40,3 @@ pub fn release_version_or_canary_commit_hash() -> &'static str {
     env!("CARGO_PKG_VERSION")
   }
 }
-
-pub fn get_user_agent() -> String {
-  format!("Deno/{}", deno())
-}