summaryrefslogtreecommitdiff
path: root/cli/util/v8.rs
diff options
context:
space:
mode:
authorsnek <snek@deno.com>2024-11-14 13:16:28 +0100
committerGitHub <noreply@github.com>2024-11-14 12:16:28 +0000
commit4e899d48cffa95617266dd8f9aef54603a87ad82 (patch)
treeec667f58ccb4126ecad38bc4600d9dd8dc372ca5 /cli/util/v8.rs
parentcb107a762fb903973e0d0c2e4481baf2c0bc13b8 (diff)
fix: otel resiliency (#26857)
Improving the breadth of collected data, and ensuring that the collected data is more likely to be successfully reported. - Use `log` crate in more places - Hook up `log` crate to otel - Switch to process-wide otel processors - Handle places that use `process::exit` Also adds a more robust testing framework, with a deterministic tracing setting. Refs: https://github.com/denoland/deno/issues/26852
Diffstat (limited to 'cli/util/v8.rs')
-rw-r--r--cli/util/v8.rs9
1 files changed, 4 insertions, 5 deletions
diff --git a/cli/util/v8.rs b/cli/util/v8.rs
index fb16e67b7..6e690e6f3 100644
--- a/cli/util/v8.rs
+++ b/cli/util/v8.rs
@@ -46,15 +46,14 @@ pub fn init_v8_flags(
.skip(1)
.collect::<Vec<_>>();
- #[allow(clippy::print_stderr)]
if !unrecognized_v8_flags.is_empty() {
for f in unrecognized_v8_flags {
- eprintln!("error: V8 did not recognize flag '{f}'");
+ log::error!("error: V8 did not recognize flag '{f}'");
}
- eprintln!("\nFor a list of V8 flags, use '--v8-flags=--help'");
- std::process::exit(1);
+ log::error!("\nFor a list of V8 flags, use '--v8-flags=--help'");
+ deno_runtime::exit(1);
}
if v8_flags_includes_help {
- std::process::exit(0);
+ deno_runtime::exit(0);
}
}