diff options
author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-04-19 10:11:17 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-19 10:11:17 -0700 |
commit | b5ce9cda0dfaed4afcb85d71c2c49c82b2fe3401 (patch) | |
tree | d8bbfb54cb29976a1a40d7169e74b7533c52a037 /cli/tsc | |
parent | f4b5eec52e01249b13d795010cd995113d9ef569 (diff) |
perf(lsp): Avoid passing struct into op_resolve (#23452)
Going through serde_v8 is slow, so just pass the args separately.
`op_resolve` is especially hot, so any speedups are good.
Diffstat (limited to 'cli/tsc')
-rw-r--r-- | cli/tsc/99_main_compiler.js | 17 | ||||
-rw-r--r-- | cli/tsc/mod.rs | 15 |
2 files changed, 19 insertions, 13 deletions
diff --git a/cli/tsc/99_main_compiler.js b/cli/tsc/99_main_compiler.js index 0677b4c27..836d81f87 100644 --- a/cli/tsc/99_main_compiler.js +++ b/cli/tsc/99_main_compiler.js @@ -681,7 +681,8 @@ delete Object.prototype.__proto__; debug(`host.writeFile("${fileName}")`); } return ops.op_emit( - { fileName, data }, + data, + fileName, ); }, getCurrentDirectory() { @@ -717,10 +718,10 @@ delete Object.prototype.__proto__; : arg; if (fileReference.fileName.startsWith("npm:")) { /** @type {[string, ts.Extension] | undefined} */ - const resolved = ops.op_resolve({ - specifiers: [fileReference.fileName], - base: containingFilePath, - })?.[0]; + const resolved = ops.op_resolve( + containingFilePath, + [fileReference.fileName], + )?.[0]; if (resolved) { isCjsCache.maybeAdd(resolved); return { @@ -750,10 +751,10 @@ delete Object.prototype.__proto__; debug(` specifiers: ${specifiers.join(", ")}`); } /** @type {Array<[string, ts.Extension] | undefined>} */ - const resolved = ops.op_resolve({ - specifiers, + const resolved = ops.op_resolve( base, - }); + specifiers, + ); if (resolved) { const result = resolved.map((item) => { if (item) { diff --git a/cli/tsc/mod.rs b/cli/tsc/mod.rs index 81ea1642d..57e7dff56 100644 --- a/cli/tsc/mod.rs +++ b/cli/tsc/mod.rs @@ -412,9 +412,13 @@ struct EmitArgs { file_name: String, } -#[op2] -fn op_emit(state: &mut OpState, #[serde] args: EmitArgs) -> bool { - op_emit_inner(state, args) +#[op2(fast)] +fn op_emit( + state: &mut OpState, + #[string] data: String, + #[string] file_name: String, +) -> bool { + op_emit_inner(state, EmitArgs { data, file_name }) } #[inline] @@ -590,9 +594,10 @@ pub struct ResolveArgs { #[serde] fn op_resolve( state: &mut OpState, - #[serde] args: ResolveArgs, + #[string] base: String, + #[serde] specifiers: Vec<String>, ) -> Result<Vec<(String, String)>, AnyError> { - op_resolve_inner(state, args) + op_resolve_inner(state, ResolveArgs { base, specifiers }) } #[inline] |