diff options
author | Matt Mastracci <matthew@mastracci.com> | 2023-09-11 18:06:38 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-09-12 00:06:38 +0000 |
commit | 950e0e9cd65bd634d59fe60d5a0cb8651958c7fb (patch) | |
tree | 400dd0eaacf7ce1018a07e2e232e6d62f54112ad /cli/tsc | |
parent | bfd230fd78ef7867eec75e6b21715f51e72e7a23 (diff) |
fix(ext/http): create a graceful shutdown API (#20387)
This PR implements a graceful shutdown API for Deno.serve, allowing all
current connections to drain from the server before shutting down, while
preventing new connections from being started or new transactions on
existing connections from being created.
We split the cancellation handle into two parts: a listener handle, and
a connection handle. A graceful shutdown cancels the listener only,
while allowing the connections to drain. The connection handle aborts
all futures. If the listener handle is cancelled, we put the connections
into graceful shutdown mode, which disables keep-alive on http/1.1 and
uses http/2 mechanisms for http/2 connections.
In addition, we now guarantee that all connections are complete or
cancelled, and all resources are cleaned up when the server `finished`
promise resolves -- we use a Rust-side server refcount for this.
Performance impact: does not appear to affect basic serving performance
by more than 1% (~126k -> ~125k)
---------
Co-authored-by: Bartek IwaĆczuk <biwanczuk@gmail.com>
Diffstat (limited to 'cli/tsc')
-rw-r--r-- | cli/tsc/dts/lib.deno.unstable.d.ts | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/cli/tsc/dts/lib.deno.unstable.d.ts b/cli/tsc/dts/lib.deno.unstable.d.ts index 6a6d6c836..c8b857dc6 100644 --- a/cli/tsc/dts/lib.deno.unstable.d.ts +++ b/cli/tsc/dts/lib.deno.unstable.d.ts @@ -1936,6 +1936,17 @@ declare namespace Deno { /** The value of this unsigned 64-bit integer, represented as a bigint. */ readonly value: bigint; } + + /** An instance of the server created using `Deno.serve()` API. + * + * @category HTTP Server + */ + export interface Server { + /** Gracefully close the server. No more new connections will be accepted, + * while pending requests will be allowed to finish. + */ + shutdown(): Promise<void>; + } } /** **UNSTABLE**: New API, yet to be vetted. |