diff options
author | Aaron O'Mullan <aaron.omullan@gmail.com> | 2021-05-02 14:29:19 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-05-02 08:29:19 -0400 |
commit | 89057529bc1329e6e9e193b5aa7beeb4a02efccb (patch) | |
tree | 1560b8e0899d76341fb9b849d8be7e6452cb0d5b /cli/tsc.rs | |
parent | 948d7dd287ff86e2bb338846d8abde946d39cf09 (diff) |
clean(cli): prefix all op functions with op_ (#10463)
Makes the codebase more searchable and helps distinguish op functions from helper functions
Besides tests/examples/benches this pattern appears to be used everywhere else in the codebase
Diffstat (limited to 'cli/tsc.rs')
-rw-r--r-- | cli/tsc.rs | 40 |
1 files changed, 20 insertions, 20 deletions
diff --git a/cli/tsc.rs b/cli/tsc.rs index 167b5b110..5c43f0231 100644 --- a/cli/tsc.rs +++ b/cli/tsc.rs @@ -241,7 +241,7 @@ struct CreateHashArgs { data: String, } -fn create_hash(state: &mut State, args: Value) -> Result<Value, AnyError> { +fn op_create_hash(state: &mut State, args: Value) -> Result<Value, AnyError> { let v: CreateHashArgs = serde_json::from_value(args) .context("Invalid request from JavaScript for \"op_create_hash\".")?; let mut data = vec![v.data.as_bytes().to_owned()]; @@ -264,7 +264,7 @@ struct EmitArgs { maybe_specifiers: Option<Vec<String>>, } -fn emit(state: &mut State, args: Value) -> Result<Value, AnyError> { +fn op_emit(state: &mut State, args: Value) -> Result<Value, AnyError> { let v: EmitArgs = serde_json::from_value(args) .context("Invalid request from JavaScript for \"op_emit\".")?; match v.file_name.as_ref() { @@ -301,7 +301,7 @@ struct LoadArgs { specifier: String, } -fn load(state: &mut State, args: Value) -> Result<Value, AnyError> { +fn op_load(state: &mut State, args: Value) -> Result<Value, AnyError> { let v: LoadArgs = serde_json::from_value(args) .context("Invalid request from JavaScript for \"op_load\".")?; let specifier = resolve_url_or_path(&v.specifier) @@ -358,7 +358,7 @@ pub struct ResolveArgs { pub specifiers: Vec<String>, } -fn resolve(state: &mut State, args: Value) -> Result<Value, AnyError> { +fn op_resolve(state: &mut State, args: Value) -> Result<Value, AnyError> { let v: ResolveArgs = serde_json::from_value(args) .context("Invalid request from JavaScript for \"op_resolve\".")?; let mut resolved: Vec<(String, String)> = Vec::new(); @@ -432,7 +432,7 @@ struct RespondArgs { pub stats: Stats, } -fn respond(state: &mut State, args: Value) -> Result<Value, AnyError> { +fn op_respond(state: &mut State, args: Value) -> Result<Value, AnyError> { let v: RespondArgs = serde_json::from_value(args) .context("Error converting the result for \"op_respond\".")?; state.maybe_response = Some(v); @@ -491,11 +491,11 @@ pub fn exec(request: Request) -> Result<Response, AnyError> { )); } - runtime.register_op("op_create_hash", op(create_hash)); - runtime.register_op("op_emit", op(emit)); - runtime.register_op("op_load", op(load)); - runtime.register_op("op_resolve", op(resolve)); - runtime.register_op("op_respond", op(respond)); + runtime.register_op("op_create_hash", op(op_create_hash)); + runtime.register_op("op_emit", op(op_emit)); + runtime.register_op("op_load", op(op_load)); + runtime.register_op("op_resolve", op(op_resolve)); + runtime.register_op("op_respond", op(op_respond)); runtime.sync_ops_cache(); let startup_source = "globalThis.startup({ legacyFlag: false })"; @@ -638,7 +638,7 @@ mod tests { async fn test_create_hash() { let mut state = setup(None, Some(vec![b"something".to_vec()]), None).await; let actual = - create_hash(&mut state, json!({ "data": "some sort of content" })) + op_create_hash(&mut state, json!({ "data": "some sort of content" })) .expect("could not invoke op"); assert_eq!( actual, @@ -679,7 +679,7 @@ mod tests { #[tokio::test] async fn test_emit() { let mut state = setup(None, None, None).await; - let actual = emit( + let actual = op_emit( &mut state, json!({ "data": "some file content", @@ -707,7 +707,7 @@ mod tests { #[tokio::test] async fn test_emit_tsbuildinfo() { let mut state = setup(None, None, None).await; - let actual = emit( + let actual = op_emit( &mut state, json!({ "data": "some file content", @@ -731,7 +731,7 @@ mod tests { Some("some content".to_string()), ) .await; - let actual = load( + let actual = op_load( &mut state, json!({ "specifier": "https://deno.land/x/mod.ts"}), ) @@ -763,7 +763,7 @@ mod tests { ) .await; let value = - load(&mut state, json!({ "specifier": "asset:///lib.dom.d.ts" })) + op_load(&mut state, json!({ "specifier": "asset:///lib.dom.d.ts" })) .expect("should have invoked op"); let actual: LoadResponse = serde_json::from_value(value).expect("failed to deserialize"); @@ -782,7 +782,7 @@ mod tests { ) .await; let actual = - load(&mut state, json!({ "specifier": "deno:///.tsbuildinfo"})) + op_load(&mut state, json!({ "specifier": "deno:///.tsbuildinfo"})) .expect("should have invoked op"); assert_eq!( actual, @@ -797,7 +797,7 @@ mod tests { #[tokio::test] async fn test_load_missing_specifier() { let mut state = setup(None, None, None).await; - let actual = load( + let actual = op_load( &mut state, json!({ "specifier": "https://deno.land/x/mod.ts"}), ) @@ -820,7 +820,7 @@ mod tests { None, ) .await; - let actual = resolve( + let actual = op_resolve( &mut state, json!({ "base": "https://deno.land/x/a.ts", "specifiers": [ "./b.ts" ]}), ) @@ -836,7 +836,7 @@ mod tests { None, ) .await; - let actual = resolve( + let actual = op_resolve( &mut state, json!({ "base": "https://deno.land/x/a.ts", "specifiers": [ "./bad.ts" ]}), ).expect("should have not errored"); @@ -849,7 +849,7 @@ mod tests { #[tokio::test] async fn test_respond() { let mut state = setup(None, None, None).await; - let actual = respond( + let actual = op_respond( &mut state, json!({ "diagnostics": [ |