diff options
author | David Sherret <dsherret@users.noreply.github.com> | 2024-09-04 17:39:30 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-09-04 17:39:30 +0200 |
commit | 07ad47da53d1fbabf6fc5d26c89dc6ba683d27fd (patch) | |
tree | 9b59f66129ec8a9b6bb1737e8733fd2d352c1f98 /cli/tools | |
parent | 5400f1af6cdca6a71de80093c9d49cdde1f34ce5 (diff) |
BREAKING(config): make supported compilerOptions an allow list (#25432)
Deno has been using a deny list, which doesn't make sense because a lot
of these options don't even work.
Closes #25363
Diffstat (limited to 'cli/tools')
-rw-r--r-- | cli/tools/check.rs | 5 | ||||
-rw-r--r-- | cli/tools/compile.rs | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/cli/tools/check.rs b/cli/tools/check.rs index a2bfb9d9b..9232f324b 100644 --- a/cli/tools/check.rs +++ b/cli/tools/check.rs @@ -14,6 +14,7 @@ use deno_terminal::colors; use once_cell::sync::Lazy; use regex::Regex; +use crate::args::check_warn_tsconfig; use crate::args::CliOptions; use crate::args::TsConfig; use crate::args::TsConfigType; @@ -118,9 +119,7 @@ impl TypeChecker { .cli_options .resolve_ts_config_for_emit(TsConfigType::Check { lib: options.lib })?; if options.log_ignored_options { - if let Some(ignored_options) = ts_config_result.maybe_ignored_options { - log::warn!("{}", ignored_options); - } + check_warn_tsconfig(&ts_config_result); } let type_check_mode = options.type_check_mode; diff --git a/cli/tools/compile.rs b/cli/tools/compile.rs index 90ee0e270..b9620cfde 100644 --- a/cli/tools/compile.rs +++ b/cli/tools/compile.rs @@ -1,5 +1,6 @@ // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. +use crate::args::check_warn_tsconfig; use crate::args::CompileFlags; use crate::args::Flags; use crate::factory::CliFactory; @@ -79,6 +80,7 @@ pub async fn compile( let ts_config_for_emit = cli_options .resolve_ts_config_for_emit(deno_config::deno_json::TsConfigType::Emit)?; + check_warn_tsconfig(&ts_config_for_emit); let (transpile_options, emit_options) = crate::args::ts_config_to_transpile_and_emit_options( ts_config_for_emit.ts_config, |