summaryrefslogtreecommitdiff
path: root/cli/tools/standalone.rs
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2021-04-26 13:28:38 -0400
committerGitHub <noreply@github.com>2021-04-26 13:28:38 -0400
commitf7c298e2972e6a1eb8f9329272ed8e8c9549266c (patch)
treeed17f90092481db6e5692cff7b3066889541e01e /cli/tools/standalone.rs
parente4e7d957e8cde899d48878c83f2099b0028dfdef (diff)
Remove denort optimization (#10350)
denort is an optimization to "deno compile" to produce slightly smaller output. It's a decent idea, but causes a lot of negative side-effects: - Deno's link time is a source of constant agony both locally and in CI, denort doubles link time. - The release process is a long and arduous undertaking with many manual steps. denort necessitates an additional manual zip + upload from M1 apple computers. - The "deno compile" interface is complicated with the "--lite" option. This is confusing for uses ("why wouldn't you want lite?"). The benefits of this feature do not outweigh the negatives. We must find a different approach to optimizing "deno compile" output.
Diffstat (limited to 'cli/tools/standalone.rs')
-rw-r--r--cli/tools/standalone.rs8
1 files changed, 3 insertions, 5 deletions
diff --git a/cli/tools/standalone.rs b/cli/tools/standalone.rs
index 593d99931..37f464914 100644
--- a/cli/tools/standalone.rs
+++ b/cli/tools/standalone.rs
@@ -23,16 +23,14 @@ use crate::standalone::MAGIC_TRAILER;
pub async fn get_base_binary(
deno_dir: &DenoDir,
target: Option<String>,
- lite: bool,
) -> Result<Vec<u8>, AnyError> {
- if target.is_none() && !lite {
+ if target.is_none() {
let path = std::env::current_exe()?;
return Ok(tokio::fs::read(path).await?);
}
let target = target.unwrap_or_else(|| env!("TARGET").to_string());
- let exe_name = if lite { "denort" } else { "deno" };
- let binary_name = format!("{}-{}.zip", exe_name, target);
+ let binary_name = format!("deno-{}.zip", target);
let binary_path_suffix = if crate::version::is_canary() {
format!("canary/{}/{}", crate::version::GIT_COMMIT_HASH, binary_name)
@@ -50,7 +48,7 @@ pub async fn get_base_binary(
let archive_data = tokio::fs::read(binary_path).await?;
let base_binary_path = crate::tools::upgrade::unpack(
archive_data,
- exe_name,
+ "deno",
target.contains("windows"),
)?;
let base_binary = tokio::fs::read(base_binary_path).await?;