diff options
author | Matt Mastracci <matthew@mastracci.com> | 2023-09-18 09:39:39 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-09-18 15:39:39 +0000 |
commit | 701931477c302c0fc9dbec529af5a16c198650aa (patch) | |
tree | aac06e1034a4f626a77b51b44dcc773da412e476 /cli/tools/jupyter/mod.rs | |
parent | 0709c051f83c181206f6653396f5428df66ed74f (diff) |
fix(cli): fetch works in Jupyter (#20552)
An op2 needs to be overloaded by an op2, not an op1.
Diffstat (limited to 'cli/tools/jupyter/mod.rs')
-rw-r--r-- | cli/tools/jupyter/mod.rs | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/cli/tools/jupyter/mod.rs b/cli/tools/jupyter/mod.rs index b704d58cd..7d7104060 100644 --- a/cli/tools/jupyter/mod.rs +++ b/cli/tools/jupyter/mod.rs @@ -8,7 +8,7 @@ use crate::CliFactory; use deno_core::anyhow::Context; use deno_core::error::AnyError; use deno_core::futures::channel::mpsc; -use deno_core::op; +use deno_core::op2; use deno_core::resolve_url_or_path; use deno_core::serde::Deserialize; use deno_core::serde_json; @@ -105,22 +105,25 @@ deno_core::extension!(deno_jupyter, }, ); -#[op] +#[op2(fast)] pub fn op_print( state: &mut OpState, - msg: String, + #[string] msg: &str, is_err: bool, ) -> Result<(), AnyError> { let sender = state.borrow_mut::<mpsc::UnboundedSender<server::StdioMsg>>(); if is_err { - if let Err(err) = sender.unbounded_send(server::StdioMsg::Stderr(msg)) { + if let Err(err) = + sender.unbounded_send(server::StdioMsg::Stderr(msg.into())) + { eprintln!("Failed to send stderr message: {}", err); } return Ok(()); } - if let Err(err) = sender.unbounded_send(server::StdioMsg::Stdout(msg)) { + if let Err(err) = sender.unbounded_send(server::StdioMsg::Stdout(msg.into())) + { eprintln!("Failed to send stdout message: {}", err); } Ok(()) |