summaryrefslogtreecommitdiff
path: root/cli/tools/jupyter/install.rs
diff options
context:
space:
mode:
authorDavid Sherret <dsherret@users.noreply.github.com>2024-05-08 22:45:06 -0400
committerGitHub <noreply@github.com>2024-05-08 22:45:06 -0400
commit47f7bed677a6b72e873712de8f3988ea891710e4 (patch)
tree096549459b479cf1383e65c87b77e9f9482df258 /cli/tools/jupyter/install.rs
parente6dc4dfbff25e77d2127591802229b4a74037d24 (diff)
chore: enable clippy::print_stdout and clippy::print_stderr (#23732)
1. Generally we should prefer to use the `log` crate. 2. I very often accidentally commit `eprintln`s. When we should use `println` or `eprintln`, it's not too bad to be a bit more verbose and ignore the lint rule.
Diffstat (limited to 'cli/tools/jupyter/install.rs')
-rw-r--r--cli/tools/jupyter/install.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/cli/tools/jupyter/install.rs b/cli/tools/jupyter/install.rs
index 0c9b8b3e6..69a75837e 100644
--- a/cli/tools/jupyter/install.rs
+++ b/cli/tools/jupyter/install.rs
@@ -27,13 +27,13 @@ pub fn status() -> Result<(), AnyError> {
if let Some(specs) = json_output.get("kernelspecs") {
if let Some(specs_obj) = specs.as_object() {
if specs_obj.contains_key("deno") {
- println!("✅ Deno kernel already installed");
+ log::info!("✅ Deno kernel already installed");
return Ok(());
}
}
}
- println!("ℹ️ Deno kernel is not yet installed, run `deno jupyter --install` to set it up");
+ log::warn!("ℹ️ Deno kernel is not yet installed, run `deno jupyter --install` to set it up");
Ok(())
}
@@ -108,6 +108,6 @@ pub fn install() -> Result<(), AnyError> {
}
let _ = std::fs::remove_dir(temp_dir);
- println!("✅ Deno kernelspec installed successfully.");
+ log::info!("✅ Deno kernelspec installed successfully.");
Ok(())
}