diff options
author | Evan <96965321+0xIchigo@users.noreply.github.com> | 2024-05-13 17:18:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-13 23:18:38 +0200 |
commit | 329a8ae0c098619c8f976f2035e5599094cb43f4 (patch) | |
tree | e4e022c48a1dc57a2fb59243e25c855b15b1d5cd /cli/tools/coverage | |
parent | 88529f0b47667435689c6ef4f81af80cead7d557 (diff) |
fix(cli): panic with `deno coverage` (#23353)
This PR directly addresses the issue raised in #23282 where Deno panics
if `deno coverage` is called with `--include` regex that returns no
matches.
I've opted not to change the return value of `collect_summary` for
simplicity and return an empty `HashMap` instead
Diffstat (limited to 'cli/tools/coverage')
-rw-r--r-- | cli/tools/coverage/reporter.rs | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/cli/tools/coverage/reporter.rs b/cli/tools/coverage/reporter.rs index f6f8144a4..6547f2036 100644 --- a/cli/tools/coverage/reporter.rs +++ b/cli/tools/coverage/reporter.rs @@ -52,7 +52,12 @@ pub trait CoverageReporter { file_reports: &'a Vec<(CoverageReport, String)>, ) -> CoverageSummary { let urls = file_reports.iter().map(|rep| &rep.0.url).collect(); - let root = util::find_root(urls).unwrap().to_file_path().unwrap(); + let root = match util::find_root(urls) + .and_then(|root_path| root_path.to_file_path().ok()) + { + Some(path) => path, + None => return HashMap::new(), + }; // summary by file or directory // tuple of (line hit, line miss, branch hit, branch miss, parent) let mut summary = HashMap::new(); |