diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-05-08 22:45:06 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-08 22:45:06 -0400 |
| commit | 47f7bed677a6b72e873712de8f3988ea891710e4 (patch) | |
| tree | 096549459b479cf1383e65c87b77e9f9482df258 /cli/tools/coverage/reporter.rs | |
| parent | e6dc4dfbff25e77d2127591802229b4a74037d24 (diff) | |
chore: enable clippy::print_stdout and clippy::print_stderr (#23732)
1. Generally we should prefer to use the `log` crate.
2. I very often accidentally commit `eprintln`s.
When we should use `println` or `eprintln`, it's not too bad to be a bit
more verbose and ignore the lint rule.
Diffstat (limited to 'cli/tools/coverage/reporter.rs')
| -rw-r--r-- | cli/tools/coverage/reporter.rs | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/cli/tools/coverage/reporter.rs b/cli/tools/coverage/reporter.rs index f86fd186f..f6f8144a4 100644 --- a/cli/tools/coverage/reporter.rs +++ b/cli/tools/coverage/reporter.rs @@ -103,6 +103,7 @@ struct SummaryCoverageReporter { file_reports: Vec<(CoverageReport, String)>, } +#[allow(clippy::print_stdout)] impl SummaryCoverageReporter { pub fn new() -> SummaryCoverageReporter { SummaryCoverageReporter { @@ -166,6 +167,7 @@ impl SummaryCoverageReporter { } } +#[allow(clippy::print_stdout)] impl CoverageReporter for SummaryCoverageReporter { fn report( &mut self, @@ -312,6 +314,7 @@ impl DetailedCoverageReporter { } } +#[allow(clippy::print_stdout)] impl CoverageReporter for DetailedCoverageReporter { fn report( &mut self, @@ -416,7 +419,7 @@ impl CoverageReporter for HtmlCoverageReporter { ) .unwrap(); - println!("HTML coverage report has been generated at {}", root_report); + log::info!("HTML coverage report has been generated at {}", root_report); } } |