diff options
author | David Sherret <dsherret@users.noreply.github.com> | 2022-08-11 16:59:12 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-08-11 16:59:12 -0400 |
commit | c3b04683c55fef8929e83429ec17b7a6898c6048 (patch) | |
tree | 64190eea354854ae18f0fd993d4687b870201c6a /cli/tools/bench.rs | |
parent | e4a5f9952f404e10f1b577b1477b89b155092b67 (diff) |
refactor(cli): consolidate most MainWorker related code to the same place (#15459)
Diffstat (limited to 'cli/tools/bench.rs')
-rw-r--r-- | cli/tools/bench.rs | 51 |
1 files changed, 1 insertions, 50 deletions
diff --git a/cli/tools/bench.rs b/cli/tools/bench.rs index 60bdd6280..3d52e4226 100644 --- a/cli/tools/bench.rs +++ b/cli/tools/bench.rs @@ -4,7 +4,6 @@ use crate::args::BenchFlags; use crate::args::Flags; use crate::args::TypeCheckMode; use crate::colors; -use crate::compat; use crate::create_main_worker; use crate::file_watcher; use crate::file_watcher::ResolutionResult; @@ -12,7 +11,6 @@ use crate::fs_util::collect_specifiers; use crate::fs_util::is_supported_bench_path; use crate::graph_util::contains_specifier; use crate::graph_util::graph_valid; -use crate::located_script_name; use crate::ops; use crate::proc_state::ProcState; use crate::tools::test::format_test_error; @@ -40,7 +38,6 @@ use tokio::sync::mpsc::UnboundedSender; #[derive(Debug, Clone, Deserialize)] struct BenchSpecifierOptions { - compat_mode: bool, filter: Option<String>, } @@ -367,50 +364,7 @@ async fn bench_specifier( Default::default(), ); - worker.js_runtime.execute_script( - &located_script_name!(), - r#"Deno[Deno.internal].enableTestAndBench()"#, - )?; - - if options.compat_mode { - worker.execute_side_module(&compat::GLOBAL_URL).await?; - worker.execute_side_module(&compat::MODULE_URL).await?; - - let use_esm_loader = compat::check_if_should_use_esm_loader(&specifier)?; - - if use_esm_loader { - worker.execute_side_module(&specifier).await?; - } else { - compat::load_cjs_module( - &mut worker.js_runtime, - &specifier.to_file_path().unwrap().display().to_string(), - false, - )?; - worker.run_event_loop(false).await?; - } - } else { - // We execute the module module as a side module so that import.meta.main is not set. - worker.execute_side_module(&specifier).await?; - } - - worker.dispatch_load_event(&located_script_name!())?; - - let bench_result = worker.js_runtime.execute_script( - &located_script_name!(), - r#"Deno[Deno.internal].runBenchmarks()"#, - )?; - - worker.js_runtime.resolve_value(bench_result).await?; - - loop { - if !worker.dispatch_beforeunload_event(&located_script_name!())? { - break; - } - worker.run_event_loop(false).await?; - } - worker.dispatch_unload_event(&located_script_name!())?; - - Ok(()) + worker.run_bench_specifier().await } /// Test a collection of specifiers with test modes concurrently. @@ -537,13 +491,11 @@ pub async fn run_benchmarks( check_specifiers(&ps, permissions.clone(), specifiers.clone()).await?; - let compat = ps.options.compat(); bench_specifiers( ps, permissions, specifiers, BenchSpecifierOptions { - compat_mode: compat, filter: bench_flags.filter, }, ) @@ -703,7 +655,6 @@ pub async fn run_benchmarks_with_watch( check_specifiers(&ps, permissions.clone(), specifiers.clone()).await?; let specifier_options = BenchSpecifierOptions { - compat_mode: ps.options.compat(), filter: filter.clone(), }; bench_specifiers(ps, permissions.clone(), specifiers, specifier_options) |