diff options
author | David Sherret <dsherret@users.noreply.github.com> | 2023-04-14 16:22:33 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-14 16:22:33 -0400 |
commit | 136dce67cec749dce5989ea29e88359ef79a0045 (patch) | |
tree | 38e96bbbf22dc06cdba418a35467b215f1335549 /cli/tools/bench.rs | |
parent | a4111442191fff300132259752e6d2d5613d1871 (diff) |
refactor: break up `ProcState` (#18707)
1. Breaks up functionality within `ProcState` into several other structs
to break out the responsibilities (`ProcState` is only a data struct
now).
2. Moves towards being able to inject dependencies more easily and have
functionality only require what it needs.
3. Exposes `Arc<T>` around the "service structs" instead of it being
embedded within them. The idea behind embedding them was to reduce the
verbosity of needing to pass around `Arc<...>`, but I don't think it was
exactly working and as we move more of these structs to be more
injectable I don't think the extra verbosity will be a big deal.
Diffstat (limited to 'cli/tools/bench.rs')
-rw-r--r-- | cli/tools/bench.rs | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/cli/tools/bench.rs b/cli/tools/bench.rs index da80f5b7e..0b6ef8bb1 100644 --- a/cli/tools/bench.rs +++ b/cli/tools/bench.rs @@ -422,14 +422,15 @@ async fn check_specifiers( specifiers: Vec<ModuleSpecifier>, ) -> Result<(), AnyError> { let lib = ps.options.ts_type_lib_window(); - ps.prepare_module_load( - specifiers, - false, - lib, - PermissionsContainer::allow_all(), - PermissionsContainer::new(permissions), - ) - .await?; + ps.module_load_preparer + .prepare_module_load( + specifiers, + false, + lib, + PermissionsContainer::allow_all(), + PermissionsContainer::new(permissions), + ) + .await?; Ok(()) } @@ -705,7 +706,10 @@ pub async fn run_benchmarks_with_watch( } else { bench_modules.clone() }; - let graph = ps.create_graph(bench_modules.clone()).await?; + let graph = ps + .module_graph_builder + .create_graph(bench_modules.clone()) + .await?; graph_valid_with_cli_options(&graph, &bench_modules, &ps.options)?; // TODO(@kitsonk) - This should be totally derivable from the graph. |