diff options
author | Ryan Dahl <ry@tinyclouds.org> | 2021-04-26 13:28:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-26 13:28:38 -0400 |
commit | f7c298e2972e6a1eb8f9329272ed8e8c9549266c (patch) | |
tree | ed17f90092481db6e5692cff7b3066889541e01e /cli/tests | |
parent | e4e7d957e8cde899d48878c83f2099b0028dfdef (diff) |
Remove denort optimization (#10350)
denort is an optimization to "deno compile" to produce slightly smaller
output. It's a decent idea, but causes a lot of negative side-effects:
- Deno's link time is a source of constant agony both locally and in CI,
denort doubles link time.
- The release process is a long and arduous undertaking with many manual
steps. denort necessitates an additional manual zip + upload from M1
apple computers.
- The "deno compile" interface is complicated with the "--lite" option.
This is confusing for uses ("why wouldn't you want lite?").
The benefits of this feature do not outweigh the negatives. We must find
a different approach to optimizing "deno compile" output.
Diffstat (limited to 'cli/tests')
-rw-r--r-- | cli/tests/integration_tests.rs | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/cli/tests/integration_tests.rs b/cli/tests/integration_tests.rs index 92deb9416..bb99cf49b 100644 --- a/cli/tests/integration_tests.rs +++ b/cli/tests/integration_tests.rs @@ -5637,17 +5637,6 @@ console.log("finish"); .contains("PermissionDenied: Requires write access")); } - #[test] - fn denort_direct_use_error() { - let status = Command::new(util::denort_exe_path()) - .current_dir(util::root_path()) - .spawn() - .unwrap() - .wait() - .unwrap(); - assert!(!status.success()); - } - #[tokio::test(flavor = "multi_thread", worker_threads = 2)] async fn test_resolve_dns() { use std::collections::BTreeMap; |