chore: don't expose FFI ops to user code (#22313)

This commit removes some not really necessary FFI tests and in effect
removes them from being accessible from the user code.

This lowers the number of ops accessible to user code to 16.

40 files changed, 1 insertions, 171 deletions

diff --git a/cli/tests/integration/run_tests.rs b/cli/tests/integration/run_tests.rs
index 17f4a3981..654854204 100644
--- a/cli/tests/integration/run_tests.rs
+++ b/cli/tests/integration/run_tests.rs
@@ -3603,120 +3603,6 @@ itest!(fetch_async_error_stack {
   exit_code: 1,
 });
 
-itest!(unstable_ffi_1 {
-  args: "run run/ffi/unstable_ffi_1.js",
-  output: "run/ffi/unstable_ffi_1.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_2 {
-  args: "run run/ffi/unstable_ffi_2.js",
-  output: "run/ffi/unstable_ffi_2.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_3 {
-  args: "run run/ffi/unstable_ffi_3.js",
-  output: "run/ffi/unstable_ffi_3.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_4 {
-  args: "run run/ffi/unstable_ffi_4.js",
-  output: "run/ffi/unstable_ffi_4.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_5 {
-  args: "run run/ffi/unstable_ffi_5.js",
-  output: "run/ffi/unstable_ffi_5.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_6 {
-  args: "run run/ffi/unstable_ffi_6.js",
-  output: "run/ffi/unstable_ffi_6.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_7 {
-  args: "run run/ffi/unstable_ffi_7.js",
-  output: "run/ffi/unstable_ffi_7.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_8 {
-  args: "run run/ffi/unstable_ffi_8.js",
-  output: "run/ffi/unstable_ffi_8.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_9 {
-  args: "run run/ffi/unstable_ffi_9.js",
-  output: "run/ffi/unstable_ffi_9.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_10 {
-  args: "run run/ffi/unstable_ffi_10.js",
-  output: "run/ffi/unstable_ffi_10.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_11 {
-  args: "run run/ffi/unstable_ffi_11.js",
-  output: "run/ffi/unstable_ffi_11.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_12 {
-  args: "run run/ffi/unstable_ffi_12.js",
-  output: "run/ffi/unstable_ffi_12.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_13 {
-  args: "run run/ffi/unstable_ffi_13.js",
-  output: "run/ffi/unstable_ffi_13.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_14 {
-  args: "run run/ffi/unstable_ffi_14.js",
-  output: "run/ffi/unstable_ffi_14.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_15 {
-  args: "run run/ffi/unstable_ffi_15.js",
-  output: "run/ffi/unstable_ffi_15.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_16 {
-  args: "run run/ffi/unstable_ffi_16.js",
-  output: "run/ffi/unstable_ffi_16.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_17 {
-  args: "run run/ffi/unstable_ffi_17.js",
-  output: "run/ffi/unstable_ffi_17.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_18 {
-  args: "run run/ffi/unstable_ffi_18.js",
-  output: "run/ffi/unstable_ffi_18.js.out",
-  exit_code: 70,
-});
-
-itest!(unstable_ffi_19 {
-  args: "run run/ffi/unstable_ffi_19.js",
-  output: "run/ffi/unstable_ffi_19.js.out",
-  exit_code: 70,
-});
-
 itest!(event_listener_error {
   args: "run --quiet run/event_listener_error.ts",
   output: "run/event_listener_error.ts.out",
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_1.js b/cli/tests/testdata/run/ffi/unstable_ffi_1.js
deleted file mode 100644
index 8ef77e71e..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_1.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_load({ path: "", symbols: {} });
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_1.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_1.js.out
deleted file mode 100644
index fe172c2c6..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_1.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.dlopen'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_10.js b/cli/tests/testdata/run/ffi/unstable_ffi_10.js
deleted file mode 100644
index d291c6bbc..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_10.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_i16(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_10.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_10.js.out
deleted file mode 100644
index b9fe500b5..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_10.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getInt16'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_11.js b/cli/tests/testdata/run/ffi/unstable_ffi_11.js
deleted file mode 100644
index fc00fac38..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_11.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_u32(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_11.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_11.js.out
deleted file mode 100644
index 74039db43..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_11.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getUint32'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_12.js b/cli/tests/testdata/run/ffi/unstable_ffi_12.js
deleted file mode 100644
index 6f085115d..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_12.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_i32(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_12.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_12.js.out
deleted file mode 100644
index 1a366b8c6..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_12.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getInt32'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_13.js b/cli/tests/testdata/run/ffi/unstable_ffi_13.js
deleted file mode 100644
index c3b5105db..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_13.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_u64(null, 0, new Uint32Array(2));
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_13.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_13.js.out
deleted file mode 100644
index 93afbe5ed..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_13.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getBigUint64'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_14.js b/cli/tests/testdata/run/ffi/unstable_ffi_14.js
deleted file mode 100644
index 2d095c5d6..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_14.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_f32(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_14.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_14.js.out
deleted file mode 100644
index 7f4c900f8..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_14.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getFloat32'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_15.js b/cli/tests/testdata/run/ffi/unstable_ffi_15.js
deleted file mode 100644
index a3cf2b0c5..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_15.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_f64(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_15.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_15.js.out
deleted file mode 100644
index 5e2c55968..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_15.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getFloat64'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_16.js b/cli/tests/testdata/run/ffi/unstable_ffi_16.js
deleted file mode 100644
index 2bf3759b3..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_16.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_ptr_value(null, new Uint32Array(2));
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_16.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_16.js.out
deleted file mode 100644
index 05362e5b3..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_16.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointer#value'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_17.js b/cli/tests/testdata/run/ffi/unstable_ffi_17.js
deleted file mode 100644
index 595727092..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_17.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_get_buf(null, 0, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_17.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_17.js.out
deleted file mode 100644
index c9d6ca821..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_17.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getArrayBuffer'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_18.js b/cli/tests/testdata/run/ffi/unstable_ffi_18.js
deleted file mode 100644
index fe6530aaa..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_18.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_ptr_create(1);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_18.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_18.js.out
deleted file mode 100644
index 2474f86bd..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_18.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointer#create'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_19.js b/cli/tests/testdata/run/ffi/unstable_ffi_19.js
deleted file mode 100644
index 97d650022..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_19.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_ptr_equals(null, null);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_19.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_19.js.out
deleted file mode 100644
index 8d97f87e9..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_19.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointer#equals'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_2.js b/cli/tests/testdata/run/ffi/unstable_ffi_2.js
deleted file mode 100644
index c99b1e586..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_2.js
+++ /dev/null
@@ -1,5 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_call_ptr(null, {
-  name: null,
-  parameters: [],
-  result: "void",
-}, []);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_2.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_2.js.out
deleted file mode 100644
index 094a69b5b..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_2.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafeFnPointer#call'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_3.js b/cli/tests/testdata/run/ffi/unstable_ffi_3.js
deleted file mode 100644
index 075fb3a54..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_3.js
+++ /dev/null
@@ -1,7 +0,0 @@
-const { op_ffi_call_ptr_nonblocking } = Deno[Deno.internal].core
-  .ensureFastOps();
-op_ffi_call_ptr_nonblocking(null, {
-  name: null,
-  parameters: [],
-  result: "void",
-}, []);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_3.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_3.js.out
deleted file mode 100644
index 094a69b5b..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_3.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafeFnPointer#call'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_4.js b/cli/tests/testdata/run/ffi/unstable_ffi_4.js
deleted file mode 100644
index c62905ead..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_4.js
+++ /dev/null
@@ -1,4 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_ptr_of(
-  new Uint8Array(0),
-  new Uint32Array(2),
-);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_4.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_4.js.out
deleted file mode 100644
index 55bbc063d..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_4.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointer#of'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_5.js b/cli/tests/testdata/run/ffi/unstable_ffi_5.js
deleted file mode 100644
index 416c78175..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_5.js
+++ /dev/null
@@ -1,6 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_buf_copy_into(
-  null,
-  0,
-  new Uint8Array(0),
-  0,
-);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_5.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_5.js.out
deleted file mode 100644
index 81dd950ac..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_5.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#copyInto'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_6.js b/cli/tests/testdata/run/ffi/unstable_ffi_6.js
deleted file mode 100644
index 7a079f5fb..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_6.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_cstr_read(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_6.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_6.js.out
deleted file mode 100644
index b48fc264f..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_6.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getCString'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_7.js b/cli/tests/testdata/run/ffi/unstable_ffi_7.js
deleted file mode 100644
index 1f9e5f0c0..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_7.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_u8(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_7.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_7.js.out
deleted file mode 100644
index 935ebe195..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_7.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getUint8'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_8.js b/cli/tests/testdata/run/ffi/unstable_ffi_8.js
deleted file mode 100644
index cbd0ec9ec..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_8.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_i8(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_8.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_8.js.out
deleted file mode 100644
index 02883d0c3..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_8.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getInt8'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_9.js b/cli/tests/testdata/run/ffi/unstable_ffi_9.js
deleted file mode 100644
index 9e8da12db..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_9.js
+++ /dev/null
@@ -1 +0,0 @@
-Deno[Deno.internal].core.ops.op_ffi_read_u16(null, 0);
diff --git a/cli/tests/testdata/run/ffi/unstable_ffi_9.js.out b/cli/tests/testdata/run/ffi/unstable_ffi_9.js.out
deleted file mode 100644
index 97ac97017..000000000
--- a/cli/tests/testdata/run/ffi/unstable_ffi_9.js.out
+++ /dev/null
@@ -1 +0,0 @@
-Unstable API 'Deno.UnsafePointerView#getUint16'. The `--unstable-ffi` flag must be provided.
diff --git a/cli/tests/unit/ops_test.ts b/cli/tests/unit/ops_test.ts
index ae225c78d..aca0d655a 100644
--- a/cli/tests/unit/ops_test.ts
+++ b/cli/tests/unit/ops_test.ts
@@ -1,6 +1,6 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 
-const EXPECTED_OP_COUNT = 45;
+const EXPECTED_OP_COUNT = 16;
 
 Deno.test(function checkExposedOps() {
   // @ts-ignore TS doesn't allow to index with symbol